graphql-python/graphene-django
1
1
Fork 0
mirror of https://github.com/graphql-python/graphene-django.git synced 2025-07-10 16:22:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

adding optional_fields to enforce fields to be optional

Browse Source
This commit is contained in:
mahmoudmostafa0 2023-08-24 20:29:28 +03:00
parent 0473f1a9a3
commit 56fd6c3655
2 changed files with 26 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
graphene_django/rest_framework/mutation.py
View File

@ -19,15 +19,17 @@ class SerializerMutationOptions(MutationOptions):
model_class = None model_class = None
model_operations = ["create", "update"] model_operations = ["create", "update"]
serializer_class = None serializer_class = None
optional_fields = ()
def fields_for_serializer( def fields_for_serializer(
serializer, serializer,
only_fields, only_fields,
exclude_fields, exclude_fields,
is_input=False, is_input=False,
convert_choices_to_enum=True, convert_choices_to_enum=True,
lookup_field=None, lookup_field=None,
optional_fields=(),
): ):
fields = OrderedDict() fields = OrderedDict()
for name, field in serializer.fields.items(): for name, field in serializer.fields.items():
@ -48,9 +50,11 @@ def fields_for_serializer(
if is_not_in_only or is_excluded: if is_not_in_only or is_excluded:
continue continue
is_optional = name in optional_fields
fields[name] = convert_serializer_field( fields[name] = convert_serializer_field(
field, is_input=is_input, convert_choices_to_enum=convert_choices_to_enum field, is_input=is_input, convert_choices_to_enum=convert_choices_to_enum,
force_optional=is_optional
) )
return fields return fields
@ -65,16 +69,17 @@ class SerializerMutation(ClientIDMutation):
@classmethod @classmethod
def __init_subclass_with_meta__( def __init_subclass_with_meta__(
cls, cls,
lookup_field=None, lookup_field=None,
serializer_class=None, serializer_class=None,
model_class=None, model_class=None,
model_operations=("create", "update"), model_operations=("create", "update"),
only_fields=(), only_fields=(),
exclude_fields=(), exclude_fields=(),
convert_choices_to_enum=True, convert_choices_to_enum=True,
_meta=None, _meta=None,
**options optional_fields=()
**options
): ):
if not serializer_class: if not serializer_class:
raise Exception("serializer_class is required for the SerializerMutation") raise Exception("serializer_class is required for the SerializerMutation")
@ -98,6 +103,7 @@ class SerializerMutation(ClientIDMutation):
is_input=True, is_input=True,
convert_choices_to_enum=convert_choices_to_enum, convert_choices_to_enum=convert_choices_to_enum,
lookup_field=lookup_field, lookup_field=lookup_field,
optional_fields=optional_fields
) )
output_fields = fields_for_serializer( output_fields = fields_for_serializer(
serializer, serializer,

5
graphene_django/rest_framework/serializer_converter.py
View File

@ -18,7 +18,8 @@ def get_graphene_type_from_serializer_field(field):
) )
def convert_serializer_field(field, is_input=True, convert_choices_to_enum=True): def convert_serializer_field(field, is_input=True, convert_choices_to_enum=True,
force_optional=False):
""" """
Converts a django rest frameworks field to a graphql field Converts a django rest frameworks field to a graphql field
and marks the field as required if we are creating an input type and marks the field as required if we are creating an input type
@ -31,7 +32,7 @@ def convert_serializer_field(field, is_input=True, convert_choices_to_enum=True)
graphql_type = get_graphene_type_from_serializer_field(field) graphql_type = get_graphene_type_from_serializer_field(field)
args = [] args = []
kwargs = {"description": field.help_text, "required": is_input and field.required} kwargs = {"description": field.help_text, "required": is_input and field.required and not force_optional}
# if it is a tuple or a list it means that we are returning # if it is a tuple or a list it means that we are returning
# the graphql type and the child type # the graphql type and the child type