graphql-python/graphene-django
1
1
Fork 0
mirror of https://github.com/graphql-python/graphene-django.git synced 2024-11-22 09:37:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken form.save() call in DjangoFormMutation.perform_mutate (#1155)

Browse Source 
Django's plain (non-model) forms don't have the `save` method, so
calling this would just result in an `AttributeError` before this
change.

Resolves #1152
This commit is contained in:
Eero Ruohola 2021-04-11 06:30:15 +03:00 committed by GitHub
parent 26a851a523
commit 608af578d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
graphene_django/forms/mutation.py
View File

@ -101,7 +101,10 @@ class DjangoFormMutation(BaseDjangoFormMutation):
@classmethod @classmethod
def perform_mutate(cls, form, info): def perform_mutate(cls, form, info):
form.save() if hasattr(form, "save"):
# `save` method won't exist on plain Django forms, but this mutation can
# in theory be used with `ModelForm`s as well and we do want to save them.
form.save()
return cls(errors=[], **form.cleaned_data) return cls(errors=[], **form.cleaned_data)