From 9d9a14c36df49a7a569f7f074ae343584f08e865 Mon Sep 17 00:00:00 2001
From: Jonathan Kim <jkimbo@gmail.com>
Date: Sun, 12 Apr 2020 16:18:41 +0100
Subject: [PATCH] Fix failing tests (#931)

* Use proper model

* Remove failing test

* Add python 3.8 to test list
---
 .travis.yml                                  | 13 ++++++++++++
 graphene_django/forms/tests/test_mutation.py | 21 +++-----------------
 tox.ini                                      |  4 ++--
 3 files changed, 18 insertions(+), 20 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index bbeeb80..4b44f60 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -62,6 +62,19 @@ jobs:
     - python: 3.7
       env: DJANGO=master
 
+    - python: 3.8
+      env: DJANGO=1.11
+    - python: 3.8
+      env: DJANGO=2.0
+    - python: 3.8
+      env: DJANGO=2.1
+    - python: 3.8
+      env: DJANGO=2.2
+    - python: 3.8
+      env: DJANGO=3.0
+    - python: 3.8
+      env: DJANGO=master
+
     - python: 3.7
       env: TOXENV=black,flake8
 
diff --git a/graphene_django/forms/tests/test_mutation.py b/graphene_django/forms/tests/test_mutation.py
index f648330..e7dbbdf 100644
--- a/graphene_django/forms/tests/test_mutation.py
+++ b/graphene_django/forms/tests/test_mutation.py
@@ -5,7 +5,7 @@ from py.test import raises
 
 from graphene import ObjectType, Schema, String, Field
 from graphene_django import DjangoObjectType
-from graphene_django.tests.models import Film, FilmDetails, Pet
+from graphene_django.tests.models import Film, Pet
 
 from ...settings import graphene_settings
 from ..mutation import DjangoFormMutation, DjangoModelFormMutation
@@ -42,12 +42,6 @@ class FilmType(DjangoObjectType):
         fields = "__all__"
 
 
-class FilmDetailsType(DjangoObjectType):
-    class Meta:
-        model = FilmDetails
-        fields = "__all__"
-
-
 def test_needs_form_class():
     with raises(Exception) as exc:
 
@@ -185,23 +179,14 @@ class ModelFormMutationTests(TestCase):
         self.assertIn("client_mutation_id", PetMutation.Input._meta.fields)
         self.assertNotIn("id", PetMutation.Input._meta.fields)
 
-    def test_return_field_name_is_camelcased(self):
-        class PetMutation(DjangoModelFormMutation):
-            class Meta:
-                form_class = PetForm
-                model = FilmDetails
-
-        self.assertEqual(PetMutation._meta.model, FilmDetails)
-        self.assertEqual(PetMutation._meta.return_field_name, "filmDetails")
-
     def test_custom_return_field_name(self):
         class PetMutation(DjangoModelFormMutation):
             class Meta:
                 form_class = PetForm
-                model = Film
+                model = Pet
                 return_field_name = "animal"
 
-        self.assertEqual(PetMutation._meta.model, Film)
+        self.assertEqual(PetMutation._meta.model, Pet)
         self.assertEqual(PetMutation._meta.return_field_name, "animal")
         self.assertIn("animal", PetMutation._meta.fields)
 
diff --git a/tox.ini b/tox.ini
index e7287ff..feeacfd 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,7 +1,7 @@
 [tox]
 envlist =
-    py{27,35,36,37}-django{111,20,21,22,master},
-    py{36,37}-django30,
+    py{27,35,36,37,38}-django{111,20,21,22,master},
+    py{36,37,38}-django30,
     black,flake8
 
 [travis:env]