From cc44dd849b1294a6b48fe457f65ed2d2cdcfd008 Mon Sep 17 00:00:00 2001
From: Jonathan Kim <jkimbo@gmail.com>
Date: Tue, 25 Jun 2019 09:59:39 +0100
Subject: [PATCH] Rename setting and add documentation

---
 docs/settings.rst                                 | 15 +++++++++++++++
 graphene_django/forms/tests/test_mutation.py      |  4 ++--
 .../rest_framework/tests/test_mutation.py         |  4 ++--
 graphene_django/settings.py                       |  2 +-
 graphene_django/types.py                          |  6 +-----
 5 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/docs/settings.rst b/docs/settings.rst
index 4d37a99..6672fc4 100644
--- a/docs/settings.rst
+++ b/docs/settings.rst
@@ -101,3 +101,18 @@ Default: ``100``
     GRAPHENE = {
         'RELAY_CONNECTION_MAX_LIMIT': 100,
     }
+
+
+``CAMELCASE_ERRORS``
+------------------------------------
+
+When set to ``True`` field names in the ``errors`` object will be camel case.
+By default they will be snake case.
+
+Default: ``False``
+
+.. code:: python
+
+   GRAPHENE = {
+      'CAMELCASE_ERRORS': False,
+   }
diff --git a/graphene_django/forms/tests/test_mutation.py b/graphene_django/forms/tests/test_mutation.py
index 4c46702..2de5113 100644
--- a/graphene_django/forms/tests/test_mutation.py
+++ b/graphene_django/forms/tests/test_mutation.py
@@ -53,10 +53,10 @@ def test_mutation_error_camelcased():
 
     result = PetMutation.mutate_and_get_payload(None, None)
     assert {f.field for f in result.errors} == {"name", "age", "test_field"}
-    graphene_settings.DJANGO_GRAPHENE_CAMELCASE_ERRORS = True
+    graphene_settings.CAMELCASE_ERRORS = True
     result = PetMutation.mutate_and_get_payload(None, None)
     assert {f.field for f in result.errors} == {"name", "age", "testField"}
-    graphene_settings.DJANGO_GRAPHENE_CAMELCASE_ERRORS = False
+    graphene_settings.CAMELCASE_ERRORS = False
 
 
 class ModelFormMutationTests(TestCase):
diff --git a/graphene_django/rest_framework/tests/test_mutation.py b/graphene_django/rest_framework/tests/test_mutation.py
index 0dd5ad3..9d8b950 100644
--- a/graphene_django/rest_framework/tests/test_mutation.py
+++ b/graphene_django/rest_framework/tests/test_mutation.py
@@ -215,10 +215,10 @@ def test_model_mutate_and_get_payload_error():
 
 
 def test_mutation_error_camelcased():
-    graphene_settings.DJANGO_GRAPHENE_CAMELCASE_ERRORS = True
+    graphene_settings.CAMELCASE_ERRORS = True
     result = MyModelMutation.mutate_and_get_payload(None, mock_info(), **{})
     assert result.errors[0].field == "coolName"
-    graphene_settings.DJANGO_GRAPHENE_CAMELCASE_ERRORS = False
+    graphene_settings.CAMELCASE_ERRORS = False
 
 
 def test_invalid_serializer_operations():
diff --git a/graphene_django/settings.py b/graphene_django/settings.py
index 1b49dfb..af63890 100644
--- a/graphene_django/settings.py
+++ b/graphene_django/settings.py
@@ -35,7 +35,7 @@ DEFAULTS = {
     "RELAY_CONNECTION_ENFORCE_FIRST_OR_LAST": False,
     # Max items returned in ConnectionFields / FilterConnectionFields
     "RELAY_CONNECTION_MAX_LIMIT": 100,
-    "DJANGO_GRAPHENE_CAMELCASE_ERRORS": False,
+    "CAMELCASE_ERRORS": False,
 }
 
 if settings.DEBUG:
diff --git a/graphene_django/types.py b/graphene_django/types.py
index c296707..9b1cb08 100644
--- a/graphene_django/types.py
+++ b/graphene_django/types.py
@@ -191,9 +191,5 @@ class ErrorType(ObjectType):
 
     @classmethod
     def from_errors(cls, errors):
-        data = (
-            camelize(errors)
-            if graphene_settings.DJANGO_GRAPHENE_CAMELCASE_ERRORS
-            else errors
-        )
+        data = camelize(errors) if graphene_settings.CAMELCASE_ERRORS else errors
         return [ErrorType(field=key, messages=value) for key, value in data.items()]