graphql-python/graphene-django
1
1
Fork 0
mirror of https://github.com/graphql-python/graphene-django.git synced 2025-07-08 14:23:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Make tests for validation rules stricter

Browse Source
This commit is contained in:
Kien Dang 2023-11-28 14:27:38 +08:00
parent 9561ec3bdd
commit d006547916
1 changed files with 43 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
graphene_django/tests/test_views.py
View File

@ -829,13 +829,13 @@ def test_query_errors_non_atomic(set_rollback_mock, client):
set_rollback_mock.assert_not_called() set_rollback_mock.assert_not_called()
validation_urls = [ VALIDATION_URLS = [
"/graphql/validation/", "/graphql/validation/",
"/graphql/validation/alternative/", "/graphql/validation/alternative/",
"/graphql/validation/inherited/", "/graphql/validation/inherited/",
] ]
query_with_two_introspections = """ QUERY_WITH_TWO_INTROSPECTIONS = """
query Instrospection { query Instrospection {
queryType: __schema { queryType: __schema {
queryType {name} queryType {name}
@ -846,8 +846,10 @@ query Instrospection {
} }
""" """
introspection_disallow_error_message = "introspection is disabled" N_INTROSPECTIONS = 2
max_validation_errors_exceeded_message = "too many validation errors"
INTROSPECTION_DISALLOWED_ERROR_MESSAGE = "introspection is disabled"
MAX_VALIDATION_ERRORS_EXCEEDED_MESSAGE = "too many validation errors"
@pytest.mark.urls("graphene_django.tests.urls_validation") @pytest.mark.urls("graphene_django.tests.urls_validation")
@ -862,34 +864,60 @@ def test_allow_introspection(client):
} }
@pytest.mark.parametrize("url", validation_urls) @pytest.mark.parametrize("url", VALIDATION_URLS)
@pytest.mark.urls("graphene_django.tests.urls_validation") @pytest.mark.urls("graphene_django.tests.urls_validation")
def test_validation_disallow_introspection(client, url): def test_validation_disallow_introspection(client, url):
response = client.post(url_string(url, query="{__schema {queryType {name}}}")) response = client.post(url_string(url, query="{__schema {queryType {name}}}"))
assert response.status_code == 400 assert response.status_code == 400
assert introspection_disallow_error_message in response.content.decode()
json_response = response_json(response)
assert "data" not in json_response
assert "errors" in json_response
assert len(json_response["errors"]) == 1
error_message = json_response["errors"][0]["message"]
assert INTROSPECTION_DISALLOWED_ERROR_MESSAGE in error_message
@pytest.mark.parametrize("url", validation_urls) @pytest.mark.parametrize("url", VALIDATION_URLS)
@pytest.mark.urls("graphene_django.tests.urls_validation") @pytest.mark.urls("graphene_django.tests.urls_validation")
@patch("graphene_django.settings.graphene_settings.MAX_VALIDATION_ERRORS", 2) @patch(
"graphene_django.settings.graphene_settings.MAX_VALIDATION_ERRORS", N_INTROSPECTIONS
)
def test_within_max_validation_errors(client, url): def test_within_max_validation_errors(client, url):
response = client.post(url_string(url, query=query_with_two_introspections)) response = client.post(url_string(url, query=QUERY_WITH_TWO_INTROSPECTIONS))
assert response.status_code == 400 assert response.status_code == 400
text_response = response.content.decode().lower() json_response = response_json(response)
assert "data" not in json_response
assert "errors" in json_response
assert len(json_response["errors"]) == N_INTROSPECTIONS
assert text_response.count(introspection_disallow_error_message) == 2 error_messages = [error["message"].lower() for error in json_response["errors"]]
assert max_validation_errors_exceeded_message not in text_response
n_introspection_error_messages = sum(
INTROSPECTION_DISALLOWED_ERROR_MESSAGE in msg for msg in error_messages
)
assert n_introspection_error_messages == N_INTROSPECTIONS
assert all(
MAX_VALIDATION_ERRORS_EXCEEDED_MESSAGE not in msg for msg in error_messages
)
@pytest.mark.parametrize("url", validation_urls) @pytest.mark.parametrize("url", VALIDATION_URLS)
@pytest.mark.urls("graphene_django.tests.urls_validation") @pytest.mark.urls("graphene_django.tests.urls_validation")
@patch("graphene_django.settings.graphene_settings.MAX_VALIDATION_ERRORS", 1) @patch("graphene_django.settings.graphene_settings.MAX_VALIDATION_ERRORS", 1)
def test_exceeds_max_validation_errors(client, url): def test_exceeds_max_validation_errors(client, url):
response = client.post(url_string(url, query=query_with_two_introspections)) response = client.post(url_string(url, query=QUERY_WITH_TWO_INTROSPECTIONS))
assert response.status_code == 400 assert response.status_code == 400
assert max_validation_errors_exceeded_message in response.content.decode().lower()
json_response = response_json(response)
assert "data" not in json_response
assert "errors" in json_response
error_messages = (error["message"].lower() for error in json_response["errors"])
assert any(MAX_VALIDATION_ERRORS_EXCEEDED_MESSAGE in msg for msg in error_messages)