From eece5f9f830adf53f95b1b3b4f077f088bc1673e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rados=C5=82aw=20Kowalski?= <radek.kwlsk@gmail.com>
Date: Fri, 7 Aug 2020 11:09:11 +0200
Subject: [PATCH] Fix setting injection with suggestions from CR

Co-authored-by: Jonathan Kim <jkimbo@gmail.com>
---
 graphene_django/static/graphene_django/graphiql.js | 2 +-
 graphene_django/templates/graphene/graphiql.html   | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/graphene_django/static/graphene_django/graphiql.js b/graphene_django/static/graphene_django/graphiql.js
index 42366a8..8c3b5ce 100644
--- a/graphene_django/static/graphene_django/graphiql.js
+++ b/graphene_django/static/graphene_django/graphiql.js
@@ -175,7 +175,7 @@
     onEditQuery: onEditQuery,
     onEditVariables: onEditVariables,
     onEditOperationName: onEditOperationName,
-    headerEditorEnabled: GRAPHENE_SETTINGS.graphiqlHeaderEditorEnabled || true,
+    headerEditorEnabled: GRAPHENE_SETTINGS.graphiqlHeaderEditorEnabled,
     query: parameters.query,
   };
   if (parameters.variables) {
diff --git a/graphene_django/templates/graphene/graphiql.html b/graphene_django/templates/graphene/graphiql.html
index bcdb348..cec4893 100644
--- a/graphene_django/templates/graphene/graphiql.html
+++ b/graphene_django/templates/graphene/graphiql.html
@@ -45,9 +45,7 @@ add "&raw" to the end of the URL within a browser.
     {% if subscription_path %}
       subscriptionPath: "{{subscription_path}}",
     {% endif %}
-    {% if header_editor_enabled %}
-      graphiqlHeaderEditorEnabled: {{ graphiql_header_editor_enabled}},
-    {% endif %}
+      graphiqlHeaderEditorEnabled: {{ graphiql_header_editor_enabled|yesno:"true,false" }},
     };
   </script>
   <script src="{% static 'graphene_django/graphiql.js' %}"></script>