From f58e47a3118fd5f2a25bb28337c2afde487e6861 Mon Sep 17 00:00:00 2001 From: Jonathan Kim Date: Thu, 26 Dec 2019 12:09:18 +0000 Subject: [PATCH] Fix tests --- graphene_django/tests/test_converter.py | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/graphene_django/tests/test_converter.py b/graphene_django/tests/test_converter.py index 3790c4a..70440ec 100644 --- a/graphene_django/tests/test_converter.py +++ b/graphene_django/tests/test_converter.py @@ -20,12 +20,19 @@ from .models import Article, Film, FilmDetails, Reporter def assert_conversion(django_field, graphene_field, *args, **kwargs): - field = django_field(help_text="Custom Help Text", null=True, *args, **kwargs) + _kwargs = kwargs.copy() + if "null" not in kwargs: + _kwargs["null"] = True + field = django_field(help_text="Custom Help Text", *args, **_kwargs) graphene_type = convert_django_field(field) assert isinstance(graphene_type, graphene_field) field = graphene_type.Field() assert field.description == "Custom Help Text" - nonnull_field = django_field(null=False, *args, **kwargs) + + _kwargs = kwargs.copy() + if "null" not in kwargs: + _kwargs["null"] = False + nonnull_field = django_field(*args, **_kwargs) if not nonnull_field.null: nonnull_graphene_type = convert_django_field(nonnull_field) nonnull_field = nonnull_graphene_type.Field() @@ -121,7 +128,11 @@ def test_should_integer_convert_int(): def test_should_boolean_convert_boolean(): - field = assert_conversion(models.BooleanField, graphene.NonNull) + assert_conversion(models.BooleanField, graphene.Boolean, null=True) + + +def test_should_boolean_convert_non_null_boolean(): + field = assert_conversion(models.BooleanField, graphene.NonNull, null=False) assert field.type.of_type == graphene.Boolean