From fc5655e1414559cb5d458c5062d74bb819316117 Mon Sep 17 00:00:00 2001 From: Jacob Foster Date: Fri, 24 Nov 2017 14:44:24 -0800 Subject: [PATCH] Django override_settings isn't working here, just patch the setting --- graphene_django/tests/test_types.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/graphene_django/tests/test_types.py b/graphene_django/tests/test_types.py index 65ed17e..4b2bb07 100644 --- a/graphene_django/tests/test_types.py +++ b/graphene_django/tests/test_types.py @@ -1,10 +1,10 @@ from mock import patch -from django.test import override_settings from graphene import Interface, ObjectType, Schema, Connection, String from graphene.relay import Node from .. import registry +from ..settings import graphene_settings from ..types import DjangoObjectType, construct_fields from .models import Article as ArticleModel from .models import Reporter as ReporterModel @@ -190,13 +190,14 @@ def test_construct_fields_ignores_fkids_by_default(): assert 'editor_id' not in fields -@override_settings(GRAPHENE={'INCLUDE_FOREIGNKEY_IDS': True}) def test_construct_fields_adds_fkids_when_setting_is_true(): + graphene_settings.INCLUDE_FOREIGNKEY_IDS = True fields = construct_fields( ArticleModel, registry.registry, (), () ) + graphene_settings.INCLUDE_FOREIGNKEY_IDS = False assert 'reporter_id' in fields assert 'editor_id' in fields