Florian Zimmermann
886ce5ef03
silence warnings
2024-07-04 11:46:58 +02:00
Kien Dang
9a773b9d7b
Use ruff in pre-commit ( #1441 )
...
* Use ruff in pre-commit
* Add pyupgrade
* Add isort
* Add bugbear
* Fix B015 Pointless comparison
* Fix B026
* B018 false positive
* Remove flake8 and isort config from setup.cfg
* Remove black and flake8 from dev dependencies
* Update black
* Show list of fixes applied with autofix on
* Fix typo
* Add C4 flake8-comprehensions
* Add ruff to dev dependencies
* Fix up
2023-08-06 01:47:00 +03:00
Laurent
0de35ca3b0
fix: fk resolver permissions leak ( #1411 )
...
* fix: fk resolver permissions leak
* fix: only one query for 1o1 relation
* tests: added queries count check
* fix: docstring
* fix: typo
* docs: added warning to authorization
* feat: added bypass_get_queryset decorator
2023-07-18 15:16:52 +03:00
Steven DeMartini
9796e93fc7
Remove obsolete tests and add note about rationale
2023-05-03 11:37:17 +03:00
Steven DeMartini
f67c5dbc8c
Revert field resolver logic to fix poor query performance
...
This reverts the change to `convert_field_to_djangomodel` introduced in
https://github.com/graphql-python/graphene-django/pull/1315 for the
reasons discussed here
https://github.com/graphql-python/graphene-django/pull/1315/files#r1015659857 .
As mentioned there, without reverting this code, "queries are forced
every time an object is resolved, making an exponential number of
queries when nesting without any possibility of optimizing".
That regression prevented `graphene-django-optimizer` from working with
`graphene-django` v3.0.0b9+ (where this change first was published), as
discussed in
https://github.com/graphql-python/graphene-django/issues/1356#issuecomment-1284718187 ,
https://github.com/tfoxy/graphene-django-optimizer/issues/86 , and
https://github.com/tfoxy/graphene-django-optimizer/pull/83#issuecomment-1451987397 .
For now, this marks the two tests that depended on this problematic code
as "expected to fail", and perhaps they can be reintroduced if there's a
way to support this logic in a way that does not prevent
`select_related` and `prefetch_related` query-optimization and introduce
nested N+1s.
As mentioned here
https://github.com/graphql-python/graphene-django/pull/1315#issuecomment-1468594361 ,
this is blocking upgrade to graphene-django v3 for many users, and
fixing this would allow many to begin upgrading and contributing to keep
graphene-django going.
2023-05-03 11:37:17 +03:00
Firas K
541caa117e
Fixes related to pr#1412 ( #1352 )
...
* fix: setup.py graphene dependency
* fix: graphene_django/tests/test_get_queryset.py format
Co-authored-by: Firas Kafri <firaskafri@Firass-MacBook-Pro-2.local>
2022-09-24 15:50:40 +03:00
Thomas Leonard
5d81ba04f9
fix: unit test for graphene pr#1412 ( #1315 )
...
* Issue #1111 : foreign key should also call get_queryset method
* fix: test for graphene PR https://github.com/graphql-python/graphene/pull/1412
Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
2022-09-23 11:45:02 +03:00
