From 4d5a091d169f1251a5d822b75a4e98de001e442b Mon Sep 17 00:00:00 2001 From: cherls <9567369+cherls@users.noreply.github.com> Date: Mon, 5 Nov 2018 13:30:05 -0500 Subject: [PATCH 1/2] Add default Field description as docstring --- graphene/types/mutation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graphene/types/mutation.py b/graphene/types/mutation.py index aa8f86bb..dd09e461 100644 --- a/graphene/types/mutation.py +++ b/graphene/types/mutation.py @@ -85,7 +85,7 @@ class Mutation(ObjectType): args=cls._meta.arguments, resolver=cls._meta.resolver, name=name, - description=description, + description=description or cls._meta.description, deprecation_reason=deprecation_reason, required=required, ) From 8e53672a1d9fed4c9849e7fd122cbf71c426e1b7 Mon Sep 17 00:00:00 2001 From: cherls <9567369+cherls@users.noreply.github.com> Date: Mon, 5 Nov 2018 13:30:09 -0500 Subject: [PATCH 2/2] Add mutation field default arg test --- graphene/types/tests/test_mutation.py | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/graphene/types/tests/test_mutation.py b/graphene/types/tests/test_mutation.py index 9755ad23..8558dc7a 100644 --- a/graphene/types/tests/test_mutation.py +++ b/graphene/types/tests/test_mutation.py @@ -139,17 +139,41 @@ def test_mutation_allow_to_have_custom_args(): class MyMutation(ObjectType): create_user = CreateUser.Field( + name="createUser", description="Create a user", deprecation_reason="Is deprecated", required=True, ) field = MyMutation._meta.fields["create_user"] + assert field.name == "createUser" assert field.description == "Create a user" assert field.deprecation_reason == "Is deprecated" assert field.type == NonNull(CreateUser) +def test_mutation_default_args_output(): + class CreateUser(Mutation): + """Description.""" + + class Arguments: + name = String() + + name = String() + + def mutate(self, info, name): + return CreateUser(name=name) + + class MyMutation(ObjectType): + create_user = CreateUser.Field() + + field = MyMutation._meta.fields["create_user"] + assert field.name is None + assert field.description == "Description." + assert field.deprecation_reason is None + assert field.type == CreateUser + + def test_mutation_as_subclass(): class BaseCreateUser(Mutation): class Arguments: