From 6967ce258f7a1c33a0162e182559bd9790482638 Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Sun, 23 Jun 2024 22:09:30 +0800 Subject: [PATCH] CI: format check using Ruff --- .github/workflows/lint.yml | 4 +++- examples/simple_example.py | 1 - .../tests/snapshots/snap_test_objectidentification.py | 4 +--- graphene/relay/tests/test_node.py | 1 - graphene/types/enum.py | 4 +--- graphene/types/tests/test_scalars_serialization.py | 2 +- graphene/utils/dataloader.py | 1 - graphene/utils/deprecated.py | 3 --- 8 files changed, 6 insertions(+), 14 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 9112718a..0b3c0fc3 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -15,7 +15,9 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install tox + pip install ruff tox + - name: Format check using Ruff + run: ruff format --check - name: Run lint run: tox env: diff --git a/examples/simple_example.py b/examples/simple_example.py index 9bee8d1f..d2685d28 100644 --- a/examples/simple_example.py +++ b/examples/simple_example.py @@ -8,7 +8,6 @@ class Patron(graphene.ObjectType): class Query(graphene.ObjectType): - patron = graphene.Field(Patron) def resolve_patron(root, info): diff --git a/examples/starwars_relay/tests/snapshots/snap_test_objectidentification.py b/examples/starwars_relay/tests/snapshots/snap_test_objectidentification.py index ab83e358..b06fb6bf 100644 --- a/examples/starwars_relay/tests/snapshots/snap_test_objectidentification.py +++ b/examples/starwars_relay/tests/snapshots/snap_test_objectidentification.py @@ -27,9 +27,7 @@ snapshots["test_correctly_refetches_xwing 1"] = { "data": {"node": {"id": "U2hpcDox", "name": "X-Wing"}} } -snapshots[ - "test_str_schema 1" -] = '''type Query { +snapshots["test_str_schema 1"] = '''type Query { rebels: Faction empire: Faction node( diff --git a/graphene/relay/tests/test_node.py b/graphene/relay/tests/test_node.py index e7564566..80181a1b 100644 --- a/graphene/relay/tests/test_node.py +++ b/graphene/relay/tests/test_node.py @@ -8,7 +8,6 @@ from ..node import Node, is_node class SharedNodeFields: - shared = String() something_else = String() diff --git a/graphene/types/enum.py b/graphene/types/enum.py index d3469a15..bc61cd4c 100644 --- a/graphene/types/enum.py +++ b/graphene/types/enum.py @@ -61,9 +61,7 @@ class EnumMeta(SubclassWithMeta_Meta): def __iter__(cls): return cls._meta.enum.__iter__() - def from_enum( - cls, enum, name=None, description=None, deprecation_reason=None - ): # noqa: N805 + def from_enum(cls, enum, name=None, description=None, deprecation_reason=None): # noqa: N805 name = name or enum.__name__ description = description or enum.__doc__ or "An enumeration." meta_dict = { diff --git a/graphene/types/tests/test_scalars_serialization.py b/graphene/types/tests/test_scalars_serialization.py index a0028c85..4af8a413 100644 --- a/graphene/types/tests/test_scalars_serialization.py +++ b/graphene/types/tests/test_scalars_serialization.py @@ -39,7 +39,7 @@ def test_serializes_output_string(): assert String.serialize(-1.1) == "-1.1" assert String.serialize(True) == "true" assert String.serialize(False) == "false" - assert String.serialize("\U0001F601") == "\U0001F601" + assert String.serialize("\U0001f601") == "\U0001f601" def test_serializes_output_boolean(): diff --git a/graphene/utils/dataloader.py b/graphene/utils/dataloader.py index 143558aa..b8f4a0cd 100644 --- a/graphene/utils/dataloader.py +++ b/graphene/utils/dataloader.py @@ -33,7 +33,6 @@ class DataLoader(object): cache_map=None, loop=None, ): - self._loop = loop if batch_load_fn is not None: diff --git a/graphene/utils/deprecated.py b/graphene/utils/deprecated.py index 71a5bb40..42c358fb 100644 --- a/graphene/utils/deprecated.py +++ b/graphene/utils/deprecated.py @@ -17,7 +17,6 @@ def deprecated(reason): """ if isinstance(reason, string_types): - # The @deprecated is used with a 'reason'. # # .. code-block:: python @@ -27,7 +26,6 @@ def deprecated(reason): # pass def decorator(func1): - if inspect.isclass(func1): fmt1 = f"Call to deprecated class {func1.__name__} ({reason})." else: @@ -43,7 +41,6 @@ def deprecated(reason): return decorator elif inspect.isclass(reason) or inspect.isfunction(reason): - # The @deprecated is used without any 'reason'. # # .. code-block:: python