From 767c77381c91798456f5ff2de14e868952c0b4ce Mon Sep 17 00:00:00 2001 From: Jake Date: Sat, 10 Oct 2015 20:12:08 -0400 Subject: [PATCH] Re-enable executor mapping_type now that graphql-core==0.1a3 is out. Also use `executor.execute()` directly, which handles parsing/validation. --- graphene/core/schema.py | 33 ++++++++------------------------- setup.py | 2 +- 2 files changed, 9 insertions(+), 26 deletions(-) diff --git a/graphene/core/schema.py b/graphene/core/schema.py index 90417eea..1c6710ee 100644 --- a/graphene/core/schema.py +++ b/graphene/core/schema.py @@ -51,9 +51,8 @@ class Schema(object): @property def executor(self): if not self._executor: - # TODO: Update to map_type=OrderedDict when graphql-core - # update its package in pypi - self.executor = Executor([SynchronousExecutionMiddleware()]) + self.executor = Executor([SynchronousExecutionMiddleware()], map_type=OrderedDict) + return self._executor @executor.setter @@ -82,32 +81,16 @@ class Schema(object): def types(self): return self._internal_types - def execute(self, request='', root=None, vars=None, operation_name=None): + def execute(self, request='', root=None, variables=None, operation_name=None, **kwargs): root = root or object() - return graphql( + return self.executor.execute( self.schema, - request, + request=request, root=self.query(root), - vars=vars, - operation_name=operation_name + args=variables, + operation_name=operation_name, + **kwargs ) - # source = Source(request, 'GraphQL request') - # ast = parse(source) - # validation_errors = validate(self.schema, ast) - # if validation_errors: - # return ExecutionResult( - # errors=validation_errors, - # invalid=True, - # ) - - # return self.executor.execute( - # self.schema, - # ast, - # root=self.query(root), - # args=vars, - # operation_name=operation_name, - # validate_ast=False - # ) def introspect(self): return self.execute(introspection_query).data diff --git a/setup.py b/setup.py index 6395c82b..5ccaae14 100644 --- a/setup.py +++ b/setup.py @@ -56,7 +56,7 @@ setup( install_requires=[ 'six>=1.10.0', 'blinker', - 'graphql-core==0.1a2', + 'graphql-core==0.1a3', 'graphql-relay==0.2.0' ], tests_require=[