From 495361ef53ffc3edb3ffa0966cdcb0f67618056c Mon Sep 17 00:00:00 2001 From: Eran Kampf Date: Thu, 27 Oct 2016 10:27:13 -0700 Subject: [PATCH 1/2] Edges should be NonNull --- graphene/relay/connection.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graphene/relay/connection.py b/graphene/relay/connection.py index 20f3cceb..46dbba98 100644 --- a/graphene/relay/connection.py +++ b/graphene/relay/connection.py @@ -82,7 +82,7 @@ class ConnectionMeta(ObjectTypeMeta): class ConnectionBase(AbstractType): page_info = Field(PageInfo, name='pageInfo', required=True) - edges = List(edge) + edges = NonNull(List(edge)) bases = (ConnectionBase, ) + bases attrs = dict(attrs, _meta=options, Edge=edge) From 344d85c19e3be0dc09de228a25eaa34b666346f5 Mon Sep 17 00:00:00 2001 From: Eran Kampf Date: Thu, 27 Oct 2016 10:35:31 -0700 Subject: [PATCH 2/2] fix tests --- examples/starwars_relay/tests/test_objectidentification.py | 2 +- graphene/relay/tests/test_connection.py | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/starwars_relay/tests/test_objectidentification.py b/examples/starwars_relay/tests/test_objectidentification.py index 87394421..327d5b0c 100644 --- a/examples/starwars_relay/tests/test_objectidentification.py +++ b/examples/starwars_relay/tests/test_objectidentification.py @@ -56,7 +56,7 @@ type Ship implements Node { type ShipConnection { pageInfo: PageInfo! - edges: [ShipEdge] + edges: [ShipEdge]! } type ShipEdge { diff --git a/graphene/relay/tests/test_connection.py b/graphene/relay/tests/test_connection.py index 18d890c1..87f937ae 100644 --- a/graphene/relay/tests/test_connection.py +++ b/graphene/relay/tests/test_connection.py @@ -28,8 +28,9 @@ def test_connection(): pageinfo_field = fields['page_info'] assert isinstance(edge_field, Field) - assert isinstance(edge_field.type, List) - assert edge_field.type.of_type == MyObjectConnection.Edge + assert isinstance(edge_field.type, NonNull) + assert isinstance(edge_field.type.of_type, List) + assert edge_field.type.of_type.of_type == MyObjectConnection.Edge assert isinstance(pageinfo_field, Field) assert isinstance(pageinfo_field.type, NonNull)