From a1fc3688aa56cdf01e25d15e3be9c5f2a50694ac Mon Sep 17 00:00:00 2001 From: Jonathan Kim Date: Thu, 25 Jun 2020 03:21:40 +0100 Subject: [PATCH] Remove to_const function (#1212) --- graphene/utils/str_converters.py | 5 ----- graphene/utils/tests/test_str_converters.py | 10 +--------- setup.py | 1 - 3 files changed, 1 insertion(+), 15 deletions(-) diff --git a/graphene/utils/str_converters.py b/graphene/utils/str_converters.py index 9ac8461f..2a214f06 100644 --- a/graphene/utils/str_converters.py +++ b/graphene/utils/str_converters.py @@ -1,5 +1,4 @@ import re -from unidecode import unidecode # Adapted from this response in Stackoverflow @@ -16,7 +15,3 @@ def to_camel_case(snake_str): def to_snake_case(name): s1 = re.sub("(.)([A-Z][a-z]+)", r"\1_\2", name) return re.sub("([a-z0-9])([A-Z])", r"\1_\2", s1).lower() - - -def to_const(string): - return re.sub(r"[\W|^]+", "_", unidecode(string)).upper() diff --git a/graphene/utils/tests/test_str_converters.py b/graphene/utils/tests/test_str_converters.py index d765906c..307d6877 100644 --- a/graphene/utils/tests/test_str_converters.py +++ b/graphene/utils/tests/test_str_converters.py @@ -1,5 +1,5 @@ # coding: utf-8 -from ..str_converters import to_camel_case, to_const, to_snake_case +from ..str_converters import to_camel_case, to_snake_case def test_snake_case(): @@ -17,11 +17,3 @@ def test_camel_case(): assert to_camel_case("snakes_on_a__plane") == "snakesOnA_Plane" assert to_camel_case("i_phone_hysteria") == "iPhoneHysteria" assert to_camel_case("field_i18n") == "fieldI18n" - - -def test_to_const(): - assert to_const('snakes $1. on a "#plane') == "SNAKES_1_ON_A_PLANE" - - -def test_to_const_unicode(): - assert to_const("Skoða þetta unicode stöff") == "SKODA_THETTA_UNICODE_STOFF" diff --git a/setup.py b/setup.py index d924f9f4..34ee7dba 100644 --- a/setup.py +++ b/setup.py @@ -85,7 +85,6 @@ setup( "graphql-core>=3.1.0b1,<4", "graphql-relay>=3.0,<4", "aniso8601>=8,<9", - "unidecode>=1.1.1,<2", ], tests_require=tests_require, extras_require={"test": tests_require, "dev": dev_requires},