The default_value of InputField should be INVALID (#1111)

* The default_value of InputField should be INVALID

Since GraphQL 3.0 there is a distinction between None and INVALID (no value).
The tests captured the bug and are updated.

* Update minimum graphql-core version

* Use Undefined instead of INVALID

Co-authored-by: Jonathan Kim <jkimbo@gmail.com>
This commit is contained in:
Jean-Louis Fuchs 2020-02-08 21:24:58 +01:00 committed by GitHub
parent 9a19447213
commit ad0b3a529c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 11 additions and 13 deletions

View File

@ -46,7 +46,7 @@ type Faction implements Node {
input IntroduceShipInput {
shipName: String!
factionId: String!
clientMutationId: String = null
clientMutationId: String
}
type IntroduceShipPayload {

View File

@ -80,11 +80,11 @@ class OtherMutation(ClientIDMutation):
@staticmethod
def mutate_and_get_payload(
self, info, shared, additional_field, client_mutation_id=None
self, info, shared="", additional_field="", client_mutation_id=None
):
edge_type = MyEdge
return OtherMutation(
name=(shared or "") + (additional_field or ""),
name=shared + additional_field,
my_node_edge=edge_type(cursor="1", node=MyNode(name="name")),
)

View File

@ -1,3 +1,4 @@
from graphql import Undefined
from .mountedtype import MountedType
from .structures import NonNull
from .utils import get_type
@ -48,7 +49,7 @@ class InputField(MountedType):
self,
type,
name=None,
default_value=None,
default_value=Undefined,
deprecation_reason=None,
description=None,
required=False,

View File

@ -262,17 +262,14 @@ def test_query_input_field():
result = test_schema.execute('{ test(aInput: {aField: "String!"} ) }', "Source!")
assert not result.errors
assert result.data == {
"test": '["Source!",{"a_input":{"a_field":"String!","recursive_field":null}}]'
}
assert result.data == {"test": '["Source!",{"a_input":{"a_field":"String!"}}]'}
result = test_schema.execute(
'{ test(aInput: {recursiveField: {aField: "String!"}}) }', "Source!"
)
assert not result.errors
assert result.data == {
"test": '["Source!",{"a_input":{"a_field":null,"recursive_field":'
'{"a_field":"String!","recursive_field":null}}}]'
"test": '["Source!",{"a_input":{"recursive_field":{"a_field":"String!"}}}]'
}
@ -408,7 +405,7 @@ def test_big_list_of_containers_multiple_fields_query_benchmark(benchmark):
def test_big_list_of_containers_multiple_fields_custom_resolvers_query_benchmark(
benchmark
benchmark,
):
class Container(ObjectType):
x = Int()

View File

@ -83,7 +83,7 @@ setup(
keywords="api graphql protocol rest relay graphene",
packages=find_packages(exclude=["tests", "tests.*", "examples"]),
install_requires=[
"graphql-core>=3.0.0,<4",
"graphql-core>=3.0.3,<4",
"graphql-relay>=3.0.0,<4",
"aniso8601>=6,<9",
"unidecode>=1.1.1,<2",

View File

@ -42,11 +42,11 @@ class OtherMutation(ClientIDMutation):
@staticmethod
def mutate_and_get_payload(
self, info, shared, additional_field, client_mutation_id=None
self, info, shared="", additional_field="", client_mutation_id=None
):
edge_type = MyEdge
return OtherMutation(
name=(shared or "") + (additional_field or ""),
name=shared + additional_field,
my_node_edge=edge_type(cursor="1", node=MyNode(name="name")),
)