graphql-python/graphene
1
1
Fork 0
mirror of https://github.com/graphql-python/graphene.git synced 2024-11-22 17:46:57 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use argument's default_value regardless if the input field is required (#1326)

Browse Source 
* Use argument's default value regardless if the input field is required

* Add a test

* Format code
This commit is contained in:
Minh Tu Le 2021-04-19 10:03:11 -07:00 committed by GitHub
parent f622f1f53c
commit c08379ed85
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
graphene/types/schema.py
View File

@ -26,7 +26,6 @@ from graphql import (
GraphQLObjectType,
GraphQLSchema,
GraphQLString,
Undefined,
)
from graphql.execution import ExecutionContext
from graphql.execution.values import get_argument_values
@ -313,9 +312,7 @@ class TypeMap(dict):
arg_type,
out_name=arg_name,
description=arg.description,
default_value=Undefined
if isinstance(arg.type, NonNull)
else arg.default_value,
default_value=arg.default_value,
)
subscribe = field.wrap_subscribe(
self.get_function_for_type(

16
graphene/types/tests/test_type_map.py
View File

@ -6,6 +6,7 @@ from graphql.type import (
GraphQLInputField,
GraphQLInputObjectType,
GraphQLInterfaceType,
GraphQLNonNull,
GraphQLObjectType,
GraphQLString,
)
@ -94,6 +95,21 @@ def test_objecttype():
}
def test_required_argument_with_default_value():
class MyObjectType(ObjectType):
foo = String(bar=String(required=True, default_value="x"))
type_map = create_type_map([MyObjectType])
graphql_type = type_map["MyObjectType"]
foo_field = graphql_type.fields["foo"]
bar_argument = foo_field.args["bar"]
assert bar_argument.default_value == "x"
assert isinstance(bar_argument.type, GraphQLNonNull)
assert bar_argument.type.of_type == GraphQLString
def test_dynamic_objecttype():
class MyObjectType(ObjectType):
"""Description"""