graphql-python/graphene
1
1
Fork 0
mirror of https://github.com/graphql-python/graphene.git synced 2024-09-21 19:38:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improved upgrade example. Fixed #509

Browse Source
This commit is contained in:
Syrus Akbary 2017-07-26 20:12:15 -07:00 committed by GitHub
parent 719acc6771
commit f3bdd7de69
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
UPGRADE-v2.0.md
View File

@ -143,10 +143,10 @@ Example. Before:
```python ```python
class UserInput(InputObjectType): class UserInput(InputObjectType):
id = ID() id = ID(required=True)
def is_user_id(id): def is_valid_input(input):
return id.startswith('userid_') return input.get('id').startswith('userid_')
class Query(ObjectType): class Query(ObjectType):
user = graphene.Field(User, input=UserInput()) user = graphene.Field(User, input=UserInput())
@ -154,7 +154,7 @@ class Query(ObjectType):
@resolve_only_args @resolve_only_args
def resolve_user(self, input): def resolve_user(self, input):
user_id = input.get('id') user_id = input.get('id')
if is_user_id(user_id): if is_valid_input(user_id):
return get_user(user_id) return get_user(user_id)
``` ```
@ -162,17 +162,17 @@ With 2.0:
```python ```python
class UserInput(InputObjectType): class UserInput(InputObjectType):
id = ID() id = ID(required=True)
@property @property
def is_user_id(self): def is_valid(self):
return self.id.startswith('userid_') return self.id.startswith('userid_')
class Query(ObjectType): class Query(ObjectType):
user = graphene.Field(User, input=UserInput()) user = graphene.Field(User, input=UserInput())
def resolve_user(self, input): def resolve_user(self, input):
if input.is_user_id: if input.is_valid:
return get_user(input.id) return get_user(input.id)
``` ```