fix: bug #1278 - reverts lineheight to default 1.5 and uses padding to control layout. (#1291)

This commit is contained in:
David ODey 2018-04-17 01:25:39 -07:00 committed by Federico Zivolo
parent af1ac3a891
commit 5aefc24fbe
3 changed files with 33 additions and 2 deletions

View File

@ -10150,6 +10150,11 @@ fieldset[disabled][disabled] .has-danger .form-control, fieldset[disabled][disab
.bmd-form-group label,
.bmd-form-group input::placeholder {
line-height: 1; }
.bmd-form-group input.form-control, .bmd-form-group input.custom-file-control,
.bmd-form-group input.form-control::placeholder,
.bmd-form-group input.custom-file-control::placeholder {
padding: 0.28125rem 0;
line-height: 1.5; }
.bmd-form-group .radio label,
.bmd-form-group label.radio-inline,
.bmd-form-group .checkbox label,
@ -10204,6 +10209,11 @@ fieldset[disabled][disabled] .has-danger .form-control, fieldset[disabled][disab
.bmd-form-group.bmd-form-group-sm label,
.bmd-form-group.bmd-form-group-sm input::placeholder {
line-height: 1; }
.bmd-form-group.bmd-form-group-sm input.form-control, .bmd-form-group.bmd-form-group-sm input.custom-file-control,
.bmd-form-group.bmd-form-group-sm input.form-control::placeholder,
.bmd-form-group.bmd-form-group-sm input.custom-file-control::placeholder {
padding: 0.28125rem 0;
line-height: 1.5; }
.bmd-form-group.bmd-form-group-sm .radio label,
.bmd-form-group.bmd-form-group-sm label.radio-inline,
.bmd-form-group.bmd-form-group-sm .checkbox label,
@ -10258,6 +10268,11 @@ fieldset[disabled][disabled] .has-danger .form-control, fieldset[disabled][disab
.bmd-form-group.bmd-form-group-lg label,
.bmd-form-group.bmd-form-group-lg input::placeholder {
line-height: 1; }
.bmd-form-group.bmd-form-group-lg input.form-control, .bmd-form-group.bmd-form-group-lg input.custom-file-control,
.bmd-form-group.bmd-form-group-lg input.form-control::placeholder,
.bmd-form-group.bmd-form-group-lg input.custom-file-control::placeholder {
padding: 0.28125rem 0;
line-height: 1.5; }
.bmd-form-group.bmd-form-group-lg .radio label,
.bmd-form-group.bmd-form-group-lg label.radio-inline,
.bmd-form-group.bmd-form-group-lg .checkbox label,
@ -10312,6 +10327,12 @@ label,
input::placeholder {
line-height: 1; }
input.form-control, input.custom-file-control,
input.form-control::placeholder,
input.custom-file-control::placeholder {
padding: 0.28125rem 0;
line-height: 1.5; }
.radio label,
label.radio-inline,
.checkbox label,

File diff suppressed because one or more lines are too long

View File

@ -240,6 +240,16 @@
line-height: $variant-line-height;
}
// ^ changing the default line-height to 1 cuts the bottom of the input text off in firefox
// this is a known problem in firefox and its recommended to use the default line-height
// and use padding to control the layout. doing this also keeps the computed style height consistent
// across browsers
input.form-control,
input.form-control::placeholder {
padding:0.28125rem 0;
line-height:1.5;
}
.radio label,
label.radio-inline,
.checkbox label,