From 6bac65f47738d3bf7fe7d2043821ae6319f70b01 Mon Sep 17 00:00:00 2001 From: Kevin Ross Date: Tue, 24 Nov 2015 17:40:39 -0600 Subject: [PATCH] #738 Add csslint to the dist and address all the issues --- Gruntfile.js | 4 ++-- less/.csslintrc | 5 ++++- less/_alerts.less | 2 +- less/_checkboxes.less | 22 +++++++++++----------- less/_dialogs.less | 2 +- less/_form.less | 2 +- less/_inputs-size.less | 4 ++-- less/_inputs.less | 2 +- less/_lists.less | 4 ++-- less/_variables.less | 10 +++++----- less/plugins/_plugin-nouislider.less | 6 +++--- less/plugins/_plugin-selectize.less | 4 ++-- 12 files changed, 35 insertions(+), 32 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index aaf56e9a..1c35c47c 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -605,10 +605,10 @@ module.exports = function (grunt) { "autoprefixer:material", "autoprefixer:ripples", - //"csslint:dist", + "csslint:dist", "cssmin:material", "cssmin:ripples", - //"csslint:distmin" + "csslint:distmin" ]); grunt.registerTask("dist-js", [ diff --git a/less/.csslintrc b/less/.csslintrc index 005b8623..b23a45fe 100644 --- a/less/.csslintrc +++ b/less/.csslintrc @@ -1,4 +1,6 @@ { + "zero-units": false, + "overqualified-elements": false, "adjoining-classes": false, "box-sizing": false, "box-model": false, @@ -15,5 +17,6 @@ "text-indent": false, "unique-headings": false, "universal-selector": false, - "unqualified-attributes": false + "unqualified-attributes": false, + "fallback-colors": false } diff --git a/less/_alerts.less b/less/_alerts.less index dd7fa7a0..e010b743 100755 --- a/less/_alerts.less +++ b/less/_alerts.less @@ -1,5 +1,5 @@ .alert { - border: 0px; + border: 0; border-radius: 0; // SASS conversion note: please mirror any content change in _mixins-shared.scss alert-variations-content diff --git a/less/_checkboxes.less b/less/_checkboxes.less index 17b1a970..07d2e56f 100644 --- a/less/_checkboxes.less +++ b/less/_checkboxes.less @@ -89,7 +89,7 @@ color: @mdb-checkbox-checked-color; box-shadow: 0 0 0 10px, 10px -10px 0 10px, - 32px 0px 0 20px, + 32px 0 0 20px, 0px 32px 0 20px, -5px 5px 0 10px, 20px -12px 0 11px; @@ -137,7 +137,7 @@ box-shadow: 0 0 0 10px, 10px -10px 0 10px, - 32px 0px 0 20px, + 32px 0 0 20px, 0px 32px 0 20px, -5px 5px 0 10px, 15px 2px 0 11px; @@ -146,7 +146,7 @@ box-shadow: 0 0 0 10px, 10px -10px 0 10px, - 32px 0px 0 20px, + 32px 0 0 20px, 0px 32px 0 20px, -5px 5px 0 10px, 20px 2px 0 11px; @@ -155,7 +155,7 @@ box-shadow: 0 0 0 10px, 10px -10px 0 10px, - 32px 0px 0 20px, + 32px 0 0 20px, 0px 32px 0 20px, -5px 5px 0 10px, 20px -12px 0 11px; @@ -166,7 +166,7 @@ box-shadow: 0 0 0 10px, 10px -10px 0 10px, - 32px 0px 0 20px, + 32px 0 0 20px, 0px 32px 0 20px, -5px 5px 0 10px, 20px -12px 0 11px, @@ -177,7 +177,7 @@ box-shadow: 0 0 0 10px, 10px -10px 0 10px, - 32px 0px 0 20px, + 32px 0 0 20px, 0px 32px 0 20px, -5px 5px 0 10px, 20px -12px 0 11px, @@ -187,12 +187,12 @@ transform: rotate(45deg); margin-top: -4px; margin-left: 6px; - width: 0px; - height: 0px; + width: 0; + height: 0; box-shadow: 0 0 0 10px, 10px -10px 0 10px, - 32px 0px 0 20px, + 32px 0 0 20px, 0px 32px 0 20px, -5px 5px 0 10px, 15px 2px 0 11px, @@ -211,7 +211,7 @@ 0 0 0 0, 0 0 0 0, 0 0 0 0, - 0px 0px 0 10px inset; + 0px 0 0 10px inset; } 100% { transform: rotate(0deg); @@ -226,7 +226,7 @@ 0 0 0 0, 0 0 0 0, 0 0 0 0, - 0px 0px 0 0px inset; + 0px 0 0 0 inset; } } @keyframes rippleOn { diff --git a/less/_dialogs.less b/less/_dialogs.less index 30680e7b..9c83d6f6 100644 --- a/less/_dialogs.less +++ b/less/_dialogs.less @@ -12,7 +12,7 @@ border-bottom: none; padding-top: 24px; padding-right: 24px; - padding-bottom: 0px; + padding-bottom: 0; padding-left: 24px; } // Modal body diff --git a/less/_form.less b/less/_form.less index d6e83c2a..bf5e9fdc 100644 --- a/less/_form.less +++ b/less/_form.less @@ -5,7 +5,7 @@ .checkbox, .radio-inline, .checkbox-inline { - padding-top: 0px; + padding-top: 0; } .radio { diff --git a/less/_inputs-size.less b/less/_inputs-size.less index 93546703..63d65949 100644 --- a/less/_inputs-size.less +++ b/less/_inputs-size.less @@ -117,7 +117,7 @@ output { // The `.form-group-* form-control` variations are sadly duplicated to avoid the // issue documented in https://github.com/twbs/bootstrap/issues/15074. .input-sm { - .input-size('.input-sm', @mdb-input-height-small, @mdb-input-padding-small-vertical, @mdb-input-padding-small-horizontal, @mdb-input-font-size-small, @mdb-input-line-height-small, @mdb-input-border-radius-small); + .input-size(~".input-sm", @mdb-input-height-small, @mdb-input-padding-small-vertical, @mdb-input-padding-small-horizontal, @mdb-input-font-size-small, @mdb-input-line-height-small, @mdb-input-border-radius-small); } .form-group-sm { .form-control { @@ -144,7 +144,7 @@ output { } .input-lg { - .input-size('.input-lg', @mdb-input-height-large, @mdb-input-padding-large-vertical, @mdb-input-padding-large-horizontal, @mdb-input-font-size-large, @mdb-input-line-height-large, @mdb-input-border-radius-large); + .input-size(~".input-lg", @mdb-input-height-large, @mdb-input-padding-large-vertical, @mdb-input-padding-large-horizontal, @mdb-input-font-size-large, @mdb-input-line-height-large, @mdb-input-border-radius-large); } .form-group-lg { .form-control { diff --git a/less/_inputs.less b/less/_inputs.less index cbc08a25..675e1c52 100644 --- a/less/_inputs.less +++ b/less/_inputs.less @@ -50,7 +50,7 @@ } .help-block { - margin-top: 0px; // allow the input margin to set-off the top of the help-block + margin-top: 0; // allow the input margin to set-off the top of the help-block font-size: @help-block-font-size; } } diff --git a/less/_lists.less b/less/_lists.less index 1eeabc8f..52dc0d04 100644 --- a/less/_lists.less +++ b/less/_lists.less @@ -13,7 +13,7 @@ } } .row-picture, .row-action-primary { - float: left; + //float: left; WARNING: float can't be used with display: inline-block. Certain properties shouldn't be used with certain display property values. (display-property-grouping) Browsers: All display: inline-block; padding-right: 16px; img, i, label { @@ -66,7 +66,7 @@ .least-content { position: absolute; right: 16px; - top: 0px; + top: 0; color: rgba(0,0,0,0.54); font-size: 14px; } diff --git a/less/_variables.less b/less/_variables.less index 83f9174d..33c3b1d7 100644 --- a/less/_variables.less +++ b/less/_variables.less @@ -74,22 +74,22 @@ //## Define common padding and border radius sizes and more. Values based on 14px text and 1.428 line-height (~20px to start). @mdb-input-padding-base-vertical: 8px - 1px; // was 6. -@mdb-input-padding-base-horizontal: 0px; // was 12. -@mdb-label-as-placeholder-shim-base: 0px; // manual adjustment of label top when positioned as placeholder +@mdb-input-padding-base-horizontal: 0; // was 12. +@mdb-label-as-placeholder-shim-base: 0; // manual adjustment of label top when positioned as placeholder @mdb-label-top-margin-base: 16px; @mdb-input-padding-large-vertical: 10px - 1px; // 10 -@mdb-input-padding-large-horizontal: 0px; // 16 +@mdb-input-padding-large-horizontal: 0; // 16 @mdb-label-as-placeholder-shim-large: -4px; // manual adjustment of label top when positioned as placeholder @mdb-label-top-margin-large: 16px; @mdb-input-padding-small-vertical: 4px - 1px; // 5 -@mdb-input-padding-small-horizontal: 0px; // 10 +@mdb-input-padding-small-horizontal: 0; // 10 @mdb-label-as-placeholder-shim-small: 8px; // manual adjustment of label top when positioned as placeholder @mdb-label-top-margin-small: 12px; @mdb-input-padding-xs-vertical: 2px; // 1 -@mdb-input-padding-xs-horizontal: 0px; // 5 +@mdb-input-padding-xs-horizontal: 0; // 5 @mdb-input-border-radius-base: 0; @mdb-input-border-radius-large: 0; diff --git a/less/plugins/_plugin-nouislider.less b/less/plugins/_plugin-nouislider.less index 3dcce4c4..c5aee133 100644 --- a/less/plugins/_plugin-nouislider.less +++ b/less/plugins/_plugin-nouislider.less @@ -25,9 +25,9 @@ .noUi-stacking .noUi-handle { z-index: 10; } -.noUi-stacking + .noUi-origin { - *z-index: -1; -} +//.noUi-stacking + .noUi-origin { +// *z-index: -1; +//} WARNING: Property with star prefix found. Checks for the star property hack (targets IE6/7) (star-property-hack) Browsers: All .noUi-state-tap .noUi-origin { transition: left 0.3s, top 0.3s; } diff --git a/less/plugins/_plugin-selectize.less b/less/plugins/_plugin-selectize.less index 91f6edf8..c8e84299 100644 --- a/less/plugins/_plugin-selectize.less +++ b/less/plugins/_plugin-selectize.less @@ -33,8 +33,8 @@ } input { font-size: 14px; - outline: 0px; - border: 0px; + outline: 0; + border: 0; background: transparent; } &.label-floating-fix input {