From 1205bf9c2b123a0fbc81352af330ac2344251c62 Mon Sep 17 00:00:00 2001
From: mrmilosz <milosz@milosz.ca>
Date: Sun, 25 May 2014 04:03:07 -0400
Subject: [PATCH] callproc using a dict now has a type check to make sure the
 keys are strings.

---
 psycopg/cursor_type.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/psycopg/cursor_type.c b/psycopg/cursor_type.c
index 7992ce4b..16339971 100644
--- a/psycopg/cursor_type.c
+++ b/psycopg/cursor_type.c
@@ -1024,6 +1024,7 @@ psyco_curs_callproc(cursorObject *self, PyObject *args)
     PyObject *parameters = Py_None;
     PyObject *operation = NULL;
     PyObject *res = NULL;
+    PyObject *parameter_name = NULL;
     PyObject *parameter_names = NULL;
 
     if (!PyArg_ParseTuple(args, "s#|O",
@@ -1054,7 +1055,12 @@ psyco_curs_callproc(cursorObject *self, PyObject *args)
       /* first we need to figure out how much space we need for the SQL */
       sl = procname_len + 17 + nparameters*5 - (nparameters ? 1 : 0);
       for(i=0; i<nparameters; i++) {
-        sl += strlen(Text_AsUTF8(PyList_GetItem(parameter_names, i)));
+        parameter_name = PyList_GetItem(parameter_names, i);
+        if (!Text_Check(parameter_name)) {
+          PyErr_SetString(PyExc_TypeError, "argument 2 must have string keys if Dict");
+          goto exit;
+        }
+        sl += strlen(Text_AsUTF8(parameter_name));
       }
 
       sql = (char*)PyMem_Malloc(sl);