psycopg/psycopg2
1
1
Fork 0
mirror of https://github.com/psycopg/psycopg2.git synced 2025-06-06 06:03:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Move var setting into the only case using it

Browse Source 
The original function was more complex than this. This refactoring
avoids a false positive in the static checker
This commit is contained in:
Daniele Varrazzo 2018-12-28 03:33:53 +01:00
parent 43d779966b
commit 2a05aa2c43
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
psycopg/bytes_format.c
View File

@ -207,11 +207,6 @@ Bytes_Format(PyObject *format, PyObject *args)
"incomplete format"); "incomplete format");
goto error; goto error;
} }
if (c != '%') {
v = getnextarg(args, arglen, &argidx);
if (v == NULL)
goto error;
}
switch (c) { switch (c) {
case '%': case '%':
pbuf = "%"; pbuf = "%";
@ -219,6 +214,8 @@ Bytes_Format(PyObject *format, PyObject *args)
break; break;
case 's': case 's':
/* only bytes! */ /* only bytes! */
if (!(v = getnextarg(args, arglen, &argidx)))
goto error;
if (!Bytes_CheckExact(v)) { if (!Bytes_CheckExact(v)) {
PyErr_Format(PyExc_ValueError, PyErr_Format(PyExc_ValueError,
"only bytes values expected, got %s", "only bytes values expected, got %s",