psycopg/psycopg2
1
1
Fork 0
mirror of https://github.com/psycopg/psycopg2.git synced 2025-11-04 09:47:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix Windows 64bit lobject support for very (>2GB) large objects

Browse Source 
The type 'long' with Windows Visual C is 32bits in size for both 32bit and 64bit platforms.  Changed type of variables that could be > 2GB from long to Py_ssize_t.
This commit is contained in:
Jason Erickson 2015-06-08 11:37:23 -06:00 committed by Daniele Varrazzo
parent ab5d8f4190
commit 2cdc8d61a2
3 changed files with 24 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
psycopg/lobject.h
View File

@ -60,8 +60,8 @@ RAISES_NEG HIDDEN int lobject_export(lobjectObject *self, const char *filename);
RAISES_NEG HIDDEN Py_ssize_t lobject_read(lobjectObject *self, char *buf, size_t len); RAISES_NEG HIDDEN Py_ssize_t lobject_read(lobjectObject *self, char *buf, size_t len);
RAISES_NEG HIDDEN Py_ssize_t lobject_write(lobjectObject *self, const char *buf, RAISES_NEG HIDDEN Py_ssize_t lobject_write(lobjectObject *self, const char *buf,
size_t len); size_t len);
RAISES_NEG HIDDEN long lobject_seek(lobjectObject *self, long pos, int whence); RAISES_NEG HIDDEN Py_ssize_t lobject_seek(lobjectObject *self, Py_ssize_t pos, int whence);
RAISES_NEG HIDDEN long lobject_tell(lobjectObject *self); RAISES_NEG HIDDEN Py_ssize_t lobject_tell(lobjectObject *self);
RAISES_NEG HIDDEN int lobject_truncate(lobjectObject *self, size_t len); RAISES_NEG HIDDEN int lobject_truncate(lobjectObject *self, size_t len);
RAISES_NEG HIDDEN int lobject_close(lobjectObject *self); RAISES_NEG HIDDEN int lobject_close(lobjectObject *self);

22
psycopg/lobject_int.c
View File

@ -376,12 +376,12 @@ lobject_read(lobjectObject *self, char *buf, size_t len)
/* lobject_seek - move the current position in the lo */ /* lobject_seek - move the current position in the lo */
RAISES_NEG long RAISES_NEG Py_ssize_t
lobject_seek(lobjectObject *self, long pos, int whence) lobject_seek(lobjectObject *self, Py_ssize_t pos, int whence)
{ {
PGresult *pgres = NULL; PGresult *pgres = NULL;
char *error = NULL; char *error = NULL;
long where; Py_ssize_t where;
Dprintf("lobject_seek: fd = %d, pos = %ld, whence = %d", Dprintf("lobject_seek: fd = %d, pos = %ld, whence = %d",
self->fd, pos, whence); self->fd, pos, whence);
@ -391,12 +391,12 @@ lobject_seek(lobjectObject *self, long pos, int whence)
#ifdef HAVE_LO64 #ifdef HAVE_LO64
if (self->conn->server_version < 90300) { if (self->conn->server_version < 90300) {
where = (long)lo_lseek(self->conn->pgconn, self->fd, (int)pos, whence); where = (Py_ssize_t)lo_lseek(self->conn->pgconn, self->fd, (int)pos, whence);
} else { } else {
where = lo_lseek64(self->conn->pgconn, self->fd, pos, whence); where = (Py_ssize_t)lo_lseek64(self->conn->pgconn, self->fd, pos, whence);
} }
#else #else
where = (long)lo_lseek(self->conn->pgconn, self->fd, (int)pos, whence); where = (Py_ssize_t)lo_lseek(self->conn->pgconn, self->fd, (int)pos, whence);
#endif #endif
Dprintf("lobject_seek: where = %ld", where); Dprintf("lobject_seek: where = %ld", where);
if (where < 0) if (where < 0)
@ -412,12 +412,12 @@ lobject_seek(lobjectObject *self, long pos, int whence)
/* lobject_tell - tell the current position in the lo */ /* lobject_tell - tell the current position in the lo */
RAISES_NEG long RAISES_NEG Py_ssize_t
lobject_tell(lobjectObject *self) lobject_tell(lobjectObject *self)
{ {
PGresult *pgres = NULL; PGresult *pgres = NULL;
char *error = NULL; char *error = NULL;
long where; Py_ssize_t where;
Dprintf("lobject_tell: fd = %d", self->fd); Dprintf("lobject_tell: fd = %d", self->fd);
@ -426,12 +426,12 @@ lobject_tell(lobjectObject *self)
#ifdef HAVE_LO64 #ifdef HAVE_LO64
if (self->conn->server_version < 90300) { if (self->conn->server_version < 90300) {
where = (long)lo_tell(self->conn->pgconn, self->fd); where = (Py_ssize_t)lo_tell(self->conn->pgconn, self->fd);
} else { } else {
where = lo_tell64(self->conn->pgconn, self->fd); where = (Py_ssize_t)lo_tell64(self->conn->pgconn, self->fd);
} }
#else #else
where = (long)lo_tell(self->conn->pgconn, self->fd); where = (Py_ssize_t)lo_tell(self->conn->pgconn, self->fd);
#endif #endif
Dprintf("lobject_tell: where = %ld", where); Dprintf("lobject_tell: where = %ld", where);
if (where < 0) if (where < 0)

20
psycopg/lobject_type.c
View File

@ -105,7 +105,7 @@ psyco_lobj_write(lobjectObject *self, PyObject *args)
goto exit; goto exit;
} }
rv = PyInt_FromLong((long)res); rv = PyInt_FromSsize_t((Py_ssize_t)res);
exit: exit:
Py_XDECREF(data); Py_XDECREF(data);
@ -121,7 +121,7 @@ static PyObject *
psyco_lobj_read(lobjectObject *self, PyObject *args) psyco_lobj_read(lobjectObject *self, PyObject *args)
{ {
PyObject *res; PyObject *res;
long where, end; Py_ssize_t where, end;
Py_ssize_t size = -1; Py_ssize_t size = -1;
char *buffer; char *buffer;
@ -165,10 +165,10 @@ psyco_lobj_read(lobjectObject *self, PyObject *args)
static PyObject * static PyObject *
psyco_lobj_seek(lobjectObject *self, PyObject *args) psyco_lobj_seek(lobjectObject *self, PyObject *args)
{ {
long offset, pos=0; Py_ssize_t offset, pos=0;
int whence=0; int whence=0;
if (!PyArg_ParseTuple(args, "l|i", &offset, &whence)) if (!PyArg_ParseTuple(args, "n|i", &offset, &whence))
return NULL; return NULL;
EXC_IF_LOBJ_CLOSED(self); EXC_IF_LOBJ_CLOSED(self);
@ -197,7 +197,7 @@ psyco_lobj_seek(lobjectObject *self, PyObject *args)
if ((pos = lobject_seek(self, offset, whence)) < 0) if ((pos = lobject_seek(self, offset, whence)) < 0)
return NULL; return NULL;
return PyLong_FromLong(pos); return PyLong_FromSsize_t(pos);
} }
/* tell method - tell current position in the lobject */ /* tell method - tell current position in the lobject */
@ -208,7 +208,7 @@ psyco_lobj_seek(lobjectObject *self, PyObject *args)
static PyObject * static PyObject *
psyco_lobj_tell(lobjectObject *self, PyObject *args) psyco_lobj_tell(lobjectObject *self, PyObject *args)
{ {
long pos; Py_ssize_t pos;
EXC_IF_LOBJ_CLOSED(self); EXC_IF_LOBJ_CLOSED(self);
EXC_IF_LOBJ_LEVEL0(self); EXC_IF_LOBJ_LEVEL0(self);
@ -217,7 +217,7 @@ psyco_lobj_tell(lobjectObject *self, PyObject *args)
if ((pos = lobject_tell(self)) < 0) if ((pos = lobject_tell(self)) < 0)
return NULL; return NULL;
return PyLong_FromLong(pos); return PyLong_FromSsize_t(pos);
} }
/* unlink method - unlink (destroy) the lobject */ /* unlink method - unlink (destroy) the lobject */
@ -274,10 +274,12 @@ psyco_lobj_get_closed(lobjectObject *self, void *closure)
static PyObject * static PyObject *
psyco_lobj_truncate(lobjectObject *self, PyObject *args) psyco_lobj_truncate(lobjectObject *self, PyObject *args)
{ {
long len = 0; Py_ssize_t len = 0;
if (!PyArg_ParseTuple(args, "|l", &len)) Dprintf("psyco_lobj_truncate: Enter lobject object at %p", self);
if (!PyArg_ParseTuple(args, "|n", &len))
return NULL; return NULL;
Dprintf("psyco_lobj_truncate: Parsed Successfully");
EXC_IF_LOBJ_CLOSED(self); EXC_IF_LOBJ_CLOSED(self);
EXC_IF_LOBJ_LEVEL0(self); EXC_IF_LOBJ_LEVEL0(self);