psycopg/psycopg2
1
1
Fork 0
mirror of https://github.com/psycopg/psycopg2.git synced 2025-07-05 20:23:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

Check return code of pthread_mutex_init

Browse Source 
Close #901
This commit is contained in:
Daniele Varrazzo 2019-04-21 11:53:34 +01:00
parent 39b1994c26
commit 325aadbf2c
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
psycopg/connection_type.c
View File

@ -1349,7 +1349,7 @@ exit:
static int static int
connection_setup(connectionObject *self, const char *dsn, long int async) connection_setup(connectionObject *self, const char *dsn, long int async)
{ {
int res = -1; int rv = -1;
Dprintf("connection_setup: init connection object at %p, " Dprintf("connection_setup: init connection object at %p, "
"async %ld, refcnt = " FORMAT_CODE_PY_SSIZE_T, "async %ld, refcnt = " FORMAT_CODE_PY_SSIZE_T,
@ -1373,19 +1373,21 @@ connection_setup(connectionObject *self, const char *dsn, long int async)
/* other fields have been zeroed by tp_alloc */ /* other fields have been zeroed by tp_alloc */
pthread_mutex_init(&(self->lock), NULL); if (0 != pthread_mutex_init(&(self->lock), NULL)) {
PyErr_SetString(InternalError, "lock initialization failed");
goto exit;
}
if (conn_connect(self, async) != 0) { if (conn_connect(self, async) != 0) {
Dprintf("connection_init: FAILED"); Dprintf("connection_init: FAILED");
goto exit; goto exit;
} }
else {
Dprintf("connection_setup: good connection object at %p, refcnt = " rv = 0;
FORMAT_CODE_PY_SSIZE_T,
self, Py_REFCNT(self) Dprintf("connection_setup: good connection object at %p, refcnt = "
); FORMAT_CODE_PY_SSIZE_T,
res = 0; self, Py_REFCNT(self));
}
exit: exit:
/* here we obfuscate the password even if there was a connection error */ /* here we obfuscate the password even if there was a connection error */
@ -1395,7 +1397,7 @@ exit:
obscure_password(self); obscure_password(self);
PyErr_Restore(ptype, pvalue, ptb); PyErr_Restore(ptype, pvalue, ptb);
} }
return res; return rv;
} }