From 6f21111a92f002af7a0b8103cbd116852be49162 Mon Sep 17 00:00:00 2001 From: Daniele Varrazzo Date: Tue, 10 Jan 2012 21:51:34 +0000 Subject: [PATCH] Docs/cleanup for the lo_creat patch --- NEWS | 2 ++ psycopg/lobject_int.c | 8 +++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 1ca96e6d..21319d7b 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,8 @@ What's new in psycopg 2.4.5 - Fixed fetchmany() with no argument in cursor subclasses (ticket #84). + - Use lo_creat() instead of lo_create() when possible for better + interaction with pgpool-II (ticket #88). What's new in psycopg 2.4.4 diff --git a/psycopg/lobject_int.c b/psycopg/lobject_int.c index 373aa5f3..f180c8c2 100644 --- a/psycopg/lobject_int.c +++ b/psycopg/lobject_int.c @@ -175,10 +175,12 @@ lobject_open(lobjectObject *self, connectionObject *conn, if (new_file) self->oid = lo_import(self->conn->pgconn, new_file); else - if (new_oid != InvalidOid) + /* Use lo_creat when possible to be more middleware-friendly. + * See ticket #88 */ + if (new_oid != InvalidOid) self->oid = lo_create(self->conn->pgconn, new_oid); - else - self->oid = lo_creat(self->conn->pgconn, INV_READ | INV_WRITE); + else + self->oid = lo_creat(self->conn->pgconn, INV_READ | INV_WRITE); Dprintf("lobject_open: large object created with oid = %d", self->oid);