psycopg/psycopg2
1
1
Fork 0
mirror of https://github.com/psycopg/psycopg2.git synced 2024-11-26 10:53:44 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix PQconsumeInput usage.

Browse Source 
Only call when no data is available in the internal buffer.
This commit is contained in:
Oleksandr Shulgin 2015-07-02 14:34:09 +02:00
parent 9386653d72
commit dab41c699a
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
psycopg/pqpath.c
View File

@ -1542,14 +1542,19 @@ pq_read_replication_message(cursorObject *curs, int decode)
Dprintf("pq_read_replication_message(decode=%d)", decode); Dprintf("pq_read_replication_message(decode=%d)", decode);
retry: retry:
if (!PQconsumeInput(curs->conn->pgconn)) {
goto none;
}
Py_BEGIN_ALLOW_THREADS; Py_BEGIN_ALLOW_THREADS;
len = PQgetCopyData(curs->conn->pgconn, &buffer, 1 /* async */); len = PQgetCopyData(curs->conn->pgconn, &buffer, 1 /* async */);
Py_END_ALLOW_THREADS; Py_END_ALLOW_THREADS;
if (len == 0) { if (len == 0) {
/* We should only try reading more data into the internal buffer when
* there is nothing available at the moment. Otherwise, with a really
* highly loaded server we might be reading a number of messages for
* every single one we process, thus overgrowing the internal buffer
* until the system runs out of memory. */
if (PQconsumeInput(curs->conn->pgconn)) {
goto retry;
}
goto none; goto none;
} }