From 08f11c57a131b402f405db76dfd411b441df1ab5 Mon Sep 17 00:00:00 2001
From: Nulano <nulano@nulano.eu>
Date: Mon, 1 Jan 2024 20:52:47 +0100
Subject: [PATCH] deprecate ImageCms members: DESCRIPTION, VERSION, FLAGS,
 versions()

---
 Tests/test_imagecms.py | 13 +++++++++++--
 src/PIL/ImageCms.py    | 30 ++++++++++++++++++++++++++----
 2 files changed, 37 insertions(+), 6 deletions(-)

diff --git a/Tests/test_imagecms.py b/Tests/test_imagecms.py
index fec482f43..9575b026d 100644
--- a/Tests/test_imagecms.py
+++ b/Tests/test_imagecms.py
@@ -49,8 +49,8 @@ def skip_missing():
 def test_sanity():
     # basic smoke test.
     # this mostly follows the cms_test outline.
-
-    v = ImageCms.versions()  # should return four strings
+    with pytest.warns(DeprecationWarning):
+        v = ImageCms.versions()  # should return four strings
     assert v[0] == "1.0.0 pil"
     assert list(map(type, v)) == [str, str, str, str]
 
@@ -637,3 +637,12 @@ def test_rgb_lab(mode):
     im = Image.new("LAB", (1, 1), (255, 0, 0))
     converted_im = im.convert(mode)
     assert converted_im.getpixel((0, 0))[:3] == (0, 255, 255)
+
+
+def test_deprecation():
+    with pytest.warns(DeprecationWarning):
+        assert ImageCms.DESCRIPTION.strip().startswith("pyCMS")
+    with pytest.warns(DeprecationWarning):
+        assert ImageCms.VERSION == "1.0.0 pil"
+    with pytest.warns(DeprecationWarning):
+        assert isinstance(ImageCms.FLAGS, dict)
diff --git a/src/PIL/ImageCms.py b/src/PIL/ImageCms.py
index 62b010f45..827755bf6 100644
--- a/src/PIL/ImageCms.py
+++ b/src/PIL/ImageCms.py
@@ -20,8 +20,10 @@ import operator
 import sys
 from enum import IntEnum, IntFlag
 from functools import reduce
+from typing import Any
 
 from . import Image
+from ._deprecate import deprecate
 
 try:
     from . import _imagingcms
@@ -32,7 +34,7 @@ except ImportError as ex:
 
     _imagingcms = DeferredError.new(ex)
 
-DESCRIPTION = """
+_DESCRIPTION = """
 pyCMS
 
     a Python / PIL interface to the littleCMS ICC Color Management System
@@ -95,7 +97,22 @@ pyCMS
 
 """
 
-VERSION = "1.0.0 pil"
+_VERSION = "1.0.0 pil"
+
+
+def __getattr__(name: str) -> Any:
+    if name == "DESCRIPTION":
+        deprecate("PIL.ImageCms.DESCRIPTION", 12)
+        return _DESCRIPTION
+    elif name == "VERSION":
+        deprecate("PIL.ImageCms.VERSION", 12)
+        return _VERSION
+    elif name == "FLAGS":
+        deprecate("PIL.ImageCms.FLAGS", 12, "PIL.ImageCms.Flags")
+        return _FLAGS
+    msg = f"module '{__name__}' has no attribute '{name}'"
+    raise AttributeError(msg)
+
 
 # --------------------------------------------------------------------.
 
@@ -184,7 +201,7 @@ class Flags(IntFlag):
 _MAX_FLAG = reduce(operator.or_, Flags)
 
 
-FLAGS = {
+_FLAGS = {
     "MATRIXINPUT": 1,
     "MATRIXOUTPUT": 2,
     "MATRIXONLY": (1 | 2),
@@ -1064,4 +1081,9 @@ def versions():
     (pyCMS) Fetches versions.
     """
 
-    return VERSION, core.littlecms_version, sys.version.split()[0], Image.__version__
+    deprecate(
+        "PIL.ImageCms.versions()",
+        12,
+        '(PIL.features.version("littlecms2"), sys.version, PIL.__version__)',
+    )
+    return _VERSION, core.littlecms_version, sys.version.split()[0], Image.__version__