python-pillow/Pillow
1
1
Fork 0
mirror of https://github.com/python-pillow/Pillow.git synced 2025-03-03 19:45:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

Converted unittest mock to pytest monkeypatch

Browse Source
This commit is contained in:
Andrew Murray 2020-03-29 10:40:46 +11:00
parent cbf0bf1010
commit 30a2d694cf
1 changed files with 66 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

134
Tests/test_imagefont.py
View File

@ -3,8 +3,8 @@ import distutils.version
import os import os
import re import re
import shutil import shutil
import sys
from io import BytesIO from io import BytesIO
from unittest import mock
import pytest import pytest
from PIL import Image, ImageDraw, ImageFont from PIL import Image, ImageDraw, ImageFont
@ -459,10 +459,11 @@ class TestImageFont:
assert_image_similar_tofile(img, target, self.metrics["multiline"]) assert_image_similar_tofile(img, target, self.metrics["multiline"])
def _test_fake_loading_font(self, path_to_fake, fontname): def _test_fake_loading_font(self, monkeypatch, path_to_fake, fontname):
# Make a copy of FreeTypeFont so we can patch the original # Make a copy of FreeTypeFont so we can patch the original
free_type_font = copy.deepcopy(ImageFont.FreeTypeFont) free_type_font = copy.deepcopy(ImageFont.FreeTypeFont)
with mock.patch.object(ImageFont, "_FreeTypeFont", free_type_font, create=True): with monkeypatch.context() as m:
m.setattr(ImageFont, "_FreeTypeFont", free_type_font, raising=False)
def loadable_font(filepath, size, index, encoding, *args, **kwargs): def loadable_font(filepath, size, index, encoding, *args, **kwargs):
if filepath == path_to_fake: if filepath == path_to_fake:
@ -473,87 +474,84 @@ class TestImageFont:
filepath, size, index, encoding, *args, **kwargs filepath, size, index, encoding, *args, **kwargs
) )
with mock.patch.object(ImageFont, "FreeTypeFont", loadable_font): m.setattr(ImageFont, "FreeTypeFont", loadable_font)
font = ImageFont.truetype(fontname) font = ImageFont.truetype(fontname)
# Make sure it's loaded # Make sure it's loaded
name = font.getname() name = font.getname()
assert ("FreeMono", "Regular") == name assert ("FreeMono", "Regular") == name
@pytest.mark.skipif(is_win32(), reason="requires Unix or macOS") @pytest.mark.skipif(is_win32(), reason="requires Unix or macOS")
def test_find_linux_font(self): def test_find_linux_font(self, monkeypatch):
# A lot of mocking here - this is more for hitting code and # A lot of mocking here - this is more for hitting code and
# catching syntax like errors # catching syntax like errors
font_directory = "/usr/local/share/fonts" font_directory = "/usr/local/share/fonts"
with mock.patch("sys.platform", "linux"): monkeypatch.setattr(sys, "platform", "linux")
patched_env = {"XDG_DATA_DIRS": "/usr/share/:/usr/local/share/"} monkeypatch.setenv("XDG_DATA_DIRS", "/usr/share/:/usr/local/share/")
with mock.patch.dict(os.environ, patched_env):
def fake_walker(path): def fake_walker(path):
if path == font_directory: if path == font_directory:
return [ return [
( (
path, path,
[], [],
[ ["Arial.ttf", "Single.otf", "Duplicate.otf", "Duplicate.ttf"],
"Arial.ttf",
"Single.otf",
"Duplicate.otf",
"Duplicate.ttf",
],
)
]
return [(path, [], ["some_random_font.ttf"])]
with mock.patch("os.walk", fake_walker):
# Test that the font loads both with and without the
# extension
self._test_fake_loading_font(
font_directory + "/Arial.ttf", "Arial.ttf"
) )
self._test_fake_loading_font(font_directory + "/Arial.ttf", "Arial") ]
return [(path, [], ["some_random_font.ttf"])]
# Test that non-ttf fonts can be found without the monkeypatch.setattr(os, "walk", fake_walker)
# extension # Test that the font loads both with and without the
self._test_fake_loading_font( # extension
font_directory + "/Single.otf", "Single" self._test_fake_loading_font(
) monkeypatch, font_directory + "/Arial.ttf", "Arial.ttf"
)
self._test_fake_loading_font(
monkeypatch, font_directory + "/Arial.ttf", "Arial"
)
# Test that ttf fonts are preferred if the extension is # Test that non-ttf fonts can be found without the
# not specified # extension
self._test_fake_loading_font( self._test_fake_loading_font(
font_directory + "/Duplicate.ttf", "Duplicate" monkeypatch, font_directory + "/Single.otf", "Single"
) )
# Test that ttf fonts are preferred if the extension is
# not specified
self._test_fake_loading_font(
monkeypatch, font_directory + "/Duplicate.ttf", "Duplicate"
)
@pytest.mark.skipif(is_win32(), reason="requires Unix or macOS") @pytest.mark.skipif(is_win32(), reason="requires Unix or macOS")
def test_find_macos_font(self): def test_find_macos_font(self, monkeypatch):
# Like the linux test, more cover hitting code rather than testing # Like the linux test, more cover hitting code rather than testing
# correctness. # correctness.
font_directory = "/System/Library/Fonts" font_directory = "/System/Library/Fonts"
with mock.patch("sys.platform", "darwin"): monkeypatch.setattr(sys, "platform", "darwin")
def fake_walker(path): def fake_walker(path):
if path == font_directory: if path == font_directory:
return [ return [
( (
path, path,
[], [],
[ ["Arial.ttf", "Single.otf", "Duplicate.otf", "Duplicate.ttf"],
"Arial.ttf", )
"Single.otf", ]
"Duplicate.otf", return [(path, [], ["some_random_font.ttf"])]
"Duplicate.ttf",
],
)
]
return [(path, [], ["some_random_font.ttf"])]
with mock.patch("os.walk", fake_walker): monkeypatch.setattr(os, "walk", fake_walker)
self._test_fake_loading_font(font_directory + "/Arial.ttf", "Arial.ttf") self._test_fake_loading_font(
self._test_fake_loading_font(font_directory + "/Arial.ttf", "Arial") monkeypatch, font_directory + "/Arial.ttf", "Arial.ttf"
self._test_fake_loading_font(font_directory + "/Single.otf", "Single") )
self._test_fake_loading_font( self._test_fake_loading_font(
font_directory + "/Duplicate.ttf", "Duplicate" monkeypatch, font_directory + "/Arial.ttf", "Arial"
) )
self._test_fake_loading_font(
monkeypatch, font_directory + "/Single.otf", "Single"
)
self._test_fake_loading_font(
monkeypatch, font_directory + "/Duplicate.ttf", "Duplicate"
)
def test_imagefont_getters(self): def test_imagefont_getters(self):
# Arrange # Arrange