Upload image errors to GitHub Actions (#4135)

Upload image errors to GitHub Actions

.github/workflows/test-windows.yml

@@ -349,6 +349,13 @@ jobs:
         %PYTHON%\python.exe -m pytest -vx --cov PIL --cov-report term --cov-report xml Tests
       shell: cmd
 
+    - name: Upload errors
+      uses: actions/upload-artifact@v1
+      if: failure()
+      with:
+        name: errors
+        path: Tests/errors
+
     - name: Upload coverage
       run: 'codecov --file "%GITHUB_WORKSPACE%\coverage.xml" --name "%pythonLocation%"'
       shell: cmd

.github/workflows/test.yml

@@ -53,6 +53,13 @@ jobs:
       run: |
         .travis/test.sh
 
+    - name: Upload errors
+      uses: actions/upload-artifact@v1
+      if: failure()
+      with:
+        name: errors
+        path: Tests/errors
+
     - name: Docs
       if: matrix.python-version == 3.8
       run: |

Tests/helper.py

@@ -24,12 +24,26 @@ if os.environ.get("SHOW_ERRORS", None):
     HAS_UPLOADER = True
 
     class test_image_results:
-        @classmethod
-        def upload(self, a, b):
+        @staticmethod
+        def upload(a, b):
             a.show()
             b.show()
 
 
+elif "GITHUB_ACTIONS" in os.environ:
+    HAS_UPLOADER = True
+
+    class test_image_results:
+        @staticmethod
+        def upload(a, b):
+            dir_errors = os.path.join(os.path.dirname(__file__), "errors")
+            os.makedirs(dir_errors, exist_ok=True)
+            tmpdir = tempfile.mkdtemp(dir=dir_errors)
+            a.save(os.path.join(tmpdir, "a.png"))
+            b.save(os.path.join(tmpdir, "b.png"))
+            return tmpdir
+
+
 else:
     try:
         import test_image_results