From 6609c2590cbca5f36d9b3471d3547a6464473ce1 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Sat, 25 May 2019 12:26:27 -0700 Subject: [PATCH] Remove unnecessary repetitive .upper()/.lower() calls Plugins are always registered with th ID all uppercase and the extension all lowercase. These .upper()/.lower() calls amount to a noop. --- src/PIL/Image.py | 9 ++++----- src/PIL/PalmImagePlugin.py | 6 +++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/PIL/Image.py b/src/PIL/Image.py index 2ee7869b6..c0ca51585 100644 --- a/src/PIL/Image.py +++ b/src/PIL/Image.py @@ -2816,7 +2816,6 @@ def register_open(id, factory, accept=None): :param accept: An optional function that can be used to quickly reject images having another format. """ - id = id.upper() ID.append(id) OPEN[id] = factory, accept @@ -2829,7 +2828,7 @@ def register_mime(id, mimetype): :param id: An image format identifier. :param mimetype: The image MIME type for this format. """ - MIME[id.upper()] = mimetype + MIME[id] = mimetype def register_save(id, driver): @@ -2840,7 +2839,7 @@ def register_save(id, driver): :param id: An image format identifier. :param driver: A function to save images in this format. """ - SAVE[id.upper()] = driver + SAVE[id] = driver def register_save_all(id, driver): @@ -2852,7 +2851,7 @@ def register_save_all(id, driver): :param id: An image format identifier. :param driver: A function to save images in this format. """ - SAVE_ALL[id.upper()] = driver + SAVE_ALL[id] = driver def register_extension(id, extension): @@ -2863,7 +2862,7 @@ def register_extension(id, extension): :param id: An image format identifier. :param extension: An extension used for this format. """ - EXTENSION[extension.lower()] = id.upper() + EXTENSION[extension] = id def register_extensions(id, extensions): diff --git a/src/PIL/PalmImagePlugin.py b/src/PIL/PalmImagePlugin.py index 16b9059df..86e4dc7ec 100644 --- a/src/PIL/PalmImagePlugin.py +++ b/src/PIL/PalmImagePlugin.py @@ -226,8 +226,8 @@ def _save(im, fp, filename): # # -------------------------------------------------------------------- -Image.register_save("Palm", _save) +Image.register_save("PALM", _save) -Image.register_extension("Palm", ".palm") +Image.register_extension("PALM", ".palm") -Image.register_mime("Palm", "image/palm") +Image.register_mime("PALM", "image/palm")