Clean up Makefile [ci skip]

- Remove nose-cov comment: we know from requirements.txt that nose-cov is required.
- Phony targets comment: who cares? We'll just keep listing them all for now. URL still helpful.
- Coverage report comment: I don't get it. Reformat and add "XXX" to draw attention from someone who does.
This commit is contained in:
Alex Clark 2015-06-07 10:22:15 -04:00
parent 5f4e407927
commit 70b2be6bd5

View File

@ -1,5 +1,4 @@
# https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html # https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
# XXX Do we need all these phony targets?
.PHONY: clean coverage doc docserve help inplace install install-req release-test sdist test upload upload-test .PHONY: clean coverage doc docserve help inplace install install-req release-test sdist test upload upload-test
clean: clean:
@ -9,12 +8,10 @@ clean:
find . -name __pycache__ | xargs rm -r || true find . -name __pycache__ | xargs rm -r || true
coverage: coverage:
# requires nose-cov
coverage erase coverage erase
coverage run --parallel-mode --include=PIL/* selftest.py coverage run --parallel-mode --include=PIL/* selftest.py
nosetests --with-cov --cov='PIL/' --cov-report=html Tests/test_*.py nosetests --with-cov --cov='PIL/' --cov-report=html Tests/test_*.py
# doesn't combine properly before report, # XXX Doesn't combine properly before report, writing report instead of displaying invalid report.
# writing report instead of displaying invalid report
rm -r htmlcov || true rm -r htmlcov || true
coverage combine coverage combine
coverage report coverage report
@ -29,8 +26,8 @@ help:
@echo "Welcome to Pillow development. Please use \`make <target>' where <target> is one of" @echo "Welcome to Pillow development. Please use \`make <target>' where <target> is one of"
@echo " clean remove build products" @echo " clean remove build products"
@echo " coverage run coverage test (in progress)" @echo " coverage run coverage test (in progress)"
@echo " doc make html docs" @echo " doc make html docs"
@echo " docserve run an http server on the docs directory" @echo " docserve run an http server on the docs directory"
@echo " html to make standalone HTML files" @echo " html to make standalone HTML files"
@echo " inplace make inplace extension" @echo " inplace make inplace extension"
@echo " install make and install" @echo " install make and install"