Failing test for ResourceWarning on Python 3 #835

Tests/helper.py

@@ -111,13 +111,18 @@ class PillowTestCase(unittest.TestCase):
             result = func()
 
             # Verify some things.
-            self.assertGreaterEqual(len(w), 1)
-            found = False
-            for v in w:
-                if issubclass(v.category, warn_class):
-                    found = True
-                    break
-            self.assertTrue(found)
+            if warn_class is None:
+                self.assertEqual(len(w), 0,
+                                 "Expected no warnings, got %s" %
+                                 list(v.category for v in w))
+            else:
+                self.assertGreaterEqual(len(w), 1)
+                found = False
+                for v in w:
+                    if issubclass(v.category, warn_class):
+                        found = True
+                        break
+                self.assertTrue(found)
         return result
 
     def skipKnownBadTest(self, msg=None, platform=None,

Tests/test_image.py

@@ -237,6 +237,16 @@ class TestImage(PillowTestCase):
         im3 = Image.open('Tests/images/effect_spread.png')
         self.assert_image_similar(im2, im3, 110)
 
+    def test_no_resource_warning_on_save(self):
+        # https://github.com/python-pillow/Pillow/issues/835
+        # Arrange
+        test_file = 'Tests/images/hopper.png'
+
+        # Act/Assert
+        with Image.open(test_file) as im:
+            self.assert_warning(None, lambda: im.save('test_img.jpg'))
+
+
 if __name__ == '__main__':
     unittest.main()
 

Tests/test_numpy.py

@@ -136,10 +136,19 @@ class TestNumpy(PillowTestCase):
         im = Image.new('F', (150, 100))
         arr = numpy.zeros((15000,), numpy.float32)
         im.putdata(arr)
-
         self.assertEqual(len(im.getdata()), len(arr))
 
 
+    def test_no_resource_warning_for_numpy_array(self):
+        # https://github.com/python-pillow/Pillow/issues/835
+        # Arrange
+        from numpy import array
+        test_file = 'Tests/images/hopper.png'
+        im = Image.open(test_file)
+
+        # Act/Assert
+        self.assert_warning(None, lambda: array(im))
+
 if __name__ == '__main__':
     unittest.main()