python-pillow/Pillow
1
1
Fork 0
mirror of https://github.com/python-pillow/Pillow.git synced 2025-05-30 02:33:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4438 from jdufresne/warning

Browse Source 
Warn on typos passed to features.check()
This commit is contained in:
Hugo van Kemenade 2020-03-02 21:26:17 +02:00 committed by GitHub
commit 974233be45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Tests/test_features.py
View File

@ -44,6 +44,13 @@ def test_check_modules():
assert features.check_codec(feature) in [True, False] assert features.check_codec(feature) in [True, False]
def test_check_warns_on_nonexistent():
with pytest.warns(UserWarning) as cm:
has_feature = features.check("typo")
assert has_feature is False
assert str(cm[-1].message) == "Unknown feature 'typo'."
def test_supported_modules(): def test_supported_modules():
assert isinstance(features.get_supported_modules(), list) assert isinstance(features.get_supported_modules(), list)
assert isinstance(features.get_supported_codecs(), list) assert isinstance(features.get_supported_codecs(), list)

17
src/PIL/features.py
View File

@ -1,6 +1,7 @@
import collections import collections
import os import os
import sys import sys
import warnings
import PIL import PIL
@ -76,14 +77,14 @@ def get_supported_features():
def check(feature): def check(feature):
return ( if feature in modules:
feature in modules return check_module(feature)
and check_module(feature) if feature in codecs:
or feature in codecs return check_codec(feature)
and check_codec(feature) if feature in features:
or feature in features return check_feature(feature)
and check_feature(feature) warnings.warn("Unknown feature '%s'." % feature, stacklevel=2)
) return False
def get_supported(): def get_supported():