From d62955031b593b6f993c655eb1e4332c15818df7 Mon Sep 17 00:00:00 2001
From: Andrew Murray <3112309+radarhere@users.noreply.github.com>
Date: Thu, 1 Jan 2026 08:53:04 +1100
Subject: [PATCH] Allow for duplicate font variation styles (#9362)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
---
 Tests/fonts/AdobeVFPrototypeDuplicates.ttf | Bin 0 -> 6696 bytes
 Tests/fonts/LICENSE.txt                    |   2 +-
 Tests/test_imagefont.py                    |  17 ++++++++++++++++-
 src/PIL/ImageFont.py                       |   8 ++++++--
 src/_imagingft.c                           |   1 -
 5 files changed, 23 insertions(+), 5 deletions(-)
 create mode 100644 Tests/fonts/AdobeVFPrototypeDuplicates.ttf

diff --git a/Tests/fonts/AdobeVFPrototypeDuplicates.ttf b/Tests/fonts/AdobeVFPrototypeDuplicates.ttf
new file mode 100644
index 0000000000000000000000000000000000000000..acf0bc156c8bec3c79de96968766795951b3a8fb
GIT binary patch
literal 6696
zcmbtZdvIJ;8UN1R_id6*(o0FSEZYa|QfSyLB+xcUo2F?yO-X1<L2<yF?A>Ii`-r=n
zHbueu9#Li(29a?b90VC>Kt>$(kHQT65w+-;8AoMyz>4mG6}?yk<<fR-<L^87Y#t?8
zI^52^=l8w8^PTUW+&v{hL<SyS+T6WmaN9Q{4?RoN{4H=d_6+XajuFC-MKK1q_iXF+
z-CjBl`BAXn+&<7h_~_~H_rSr=Am6in@Ye2^{&>UFM3)3XS9a{%vgcRNJ@pOHHuN9Z
z4f@C4M}~+l{XFCc`UkH`+%Z<%1R4C%X9o9f*?Tnd`a_VP1pQC*fLU0XTYWE4%U?lX
zmjYeBF@6tGs{wj)By%XW>$e?0A=2WYcZ@)89(??9$jhL6M=djX`BUAU@ZSfza}*4J
zi{}~8Uje;(G+Ua`4$}baW1zj6{IJP<&{s2^H7CZ%PfgJO5$I^n%v#U<>+UBZpCGDx
zX)IqXJ^S2mx{1Q5foB_6iiGetC1&2ZE8O)ic|89Bhsxi5aTkwo+<jwGMvH5Yg7lNd
zTwJj8JbVsy_dW&r0A|CU=3m0~O^sM5zRs7!fhNQQ<U?-vX}3dTmph6(DIu1F>-Bql
zUZ1A1y@y@Yt}Q*?{j`~)RZV;4+}oUq=#Q!h;uV=`lr*<asEv1a1|AB~5(*PtE3OqQ
zR*7qyRy3{f;4vVc=sNdl`REd(=N{=2f7Kp6JB0foZ6j`A4t}FnQS%UV8EAJ-8oXYn
zu!pWhM3?WKr{kjp?N)q0wa^z7Zi4N1Tr51O@1qKPDM(K!>?56?R@hG;r(Y->K<$37
zaFCYK%L<3)@)0^>*^0k}g2JnC9kq%&h3m;Hu28svE)iEM944Rmgu;!qOl(!S2|Axt
zxS3XqoWe_Ksd!LfgI0<kV%3B<ggSjn{90i_8?_Y*Yt*3Kp|FScXlaGL^K^Wa)Sgp(
zKgB(lD;%JgJ^cy?N%vl%aEMlVuTgjjCA_yNT(3Rs{j$OhbX}lT;U;Pb>{hsyq5+i;
z7SJE~oXZ!2>H=R>SfgOzeuX{Ye_LTMH3lA2*hfa-S%v-78Th5b0n!6ig@bf;(5G-{
zt`1nQc(7gZmr!HSRJe{3!OtpOPr=~h3OCTY;8O~RNe})>;YRp>P2nb57h0llGwld<
zD7=)`gziz;pq|j<Tax)9E4t4tq|Kp>746OEO3{HrzLYN=8ngCTBjXvf(B2l0U$=?h
zz)ezpU+=8O`W`D~j%P}c_IGdFXBCR+d@kx5jOI(j`P>1f+S=nAHf7EIR=$+7Cah?p
zt)s28qhmwo2l-QOZ?n=Pqou7#s$dpN+a@sdG3R||bE3uNi*wcd2CZy*D4$8b&udN4
zy_k@h-5GOu|NG1&S3aV<tz>#U8?DV?aaC8TrsEp!z%(yl#ws-<+DdsEqeE1nG>y<G
zl_-ksCr<6u3ABZhkPnds9Fx)#v^UZ<_;*nLYa?@3r;Uc8orUa5YFl8t4_X|-gs+VB
z)(g#?j5YvC9*FNl@NUr_+#@s&O}1)>uQ>i)N1NcYhq|d>qFQGAs27{|`99V|)1nkS
zu%D8$?T7U?+6PI2ipYm^h%SgQD)ZoZ<mkYxtPMJG+5j(Ec-#+r&NhW{0ykHzjXH35
z;@JVc&Uv%{aQV%zbQ-xu;Wv#KqZkXIOxy+F5pav(GuJ}pqre47lb|@a0<w!DyPD17
z(iC(SM&vrU(V}!K=FYKQ|ARoLq&O=RvLsg6jlfl?Wym!fhm<3xVOw0#1HCfKoXl>!
z(s&KFCbG^#yKoWRRqK<zuyJcO*G+@SB840d%3AQ+xEdLZ!-$hZUhcd&SFRdYsy6dM
z+DUz&`(+<;P3AoJE%0zPWQ+9?cWaa`CbOi>(5>1KDp;$#+nZePD6Pe64PxAh=UR;2
zl4gqYxDEWhv;$e+ijnCpc!&1jc{Avp=y<m62Pca6y&v2jX|YpcSJn#|>wgmCE=XC2
zeJ|`n?)NcNj8~Vt!R>-HR&We&8LxU$&VLYyYk%=|jbim&uQl7ET#I3NPstUC%6%ax
zcL)<tOXkV@Mge*7YS-Ru&d}{ww&5(ftGSomH=pGrh;~5Qa?i8ZD0U(4WbTV`_~LnR
zPr0+XP`|aE*T+S49lsA_h{|sS=a#|9a~#2Y)Q=A9J8!R=dovf`JNjUK5TA%#?KE=C
zV(s1C`!?`u`#A6H?%QZ0Y6)F1fhX@3+{x}<f1yb07qz+=`-{<CxbJfh@rn&$9vRH^
z!nvMr(fy$<Ynt7%w}!DxT{zmD?i`9PSQUQT7Oug?c%8q#=lhu-v9|UfEn3aX`H}EN
zu71bOOySSmVwWHajOWtv_?EaDdxE8d`L^QtSWz#H7A#9bSJvGT%;)AY+BYPmAhC6W
zciVU&&qSiV{aSZSbcU>ADV;S-R#I{j@lJPa?@;3gPwK8T?hNjdez#RX;EY)u4M><t
z`8ga0&M1=#y7^>MfmD9H07f8{J|N}A^aRU`)&VQWKz>28LM|;G)G2?`c}Nnad@&_w
zBLN3spr*_)B!jq!!$>_2B=y`-61u^pq6{Y$Wej);@C<n52<+9J15i-<mw?@~4tr-E
z*Eu8CH!Dfk45a5_b4+^Xkv(Hno`GD?60m31Vb84NdS>K$W+mwvpuw6L&Y0O`{$P%E
z8$UbF%a_m97)>MN=}a-58_8s>REbrZXE_D_KxdXz%2?TaX@QdD%qr=lhsH*+QqZq2
zrb=^^Zsn3#eirCfwg&6R%z~Ax`D>8WtgrA;0iWa6Y`8{6&nnb2!<x00)U42N%B<^$
ztz4-sheMM>e!mq?<}>&OG)wb)gZBi#)cGu`fwXke$`|t49BDnheS4`PW0rE@`&kj1
z`0Yse%{_C6`x_b01*aO+Ecq?+yoAp~^0*&_;q$Qcy+|*DtX-RN{IT$2PEE&^&U@m-
zgMF8eRqSb}>eItUB$nvHQ3A8Y{g3_p$P1HGkRGpzTO+aciLTxxJpdKnE5wn<ju=N0
zlarI>$;zZY8JjvX1(T`Dlsy%jN|YZgf3N&Pd8%A4SIWoBcG)RMDwCC|O1V<09Ix1w
z>55a)D@G+&NmP36Ble^{WtZ(^cEz^sY1^@@w$IjW!;aW7J7Et@|6$sht~!&>lv8#p
z&T+?frX9zrIzC5t45!tJI58*TbU6c6yNVfA^{P>At*)<L?>p|ZebYY2SM~XPy8e<r
zrT;-M>lNMBr*%iK>R{?&-OwX?Oi$=tdaphZu7-VKJsdVBjVYsSR1Dj24BZGDh7mDh
zM#AVadLwqkiBuzc#E3*9u}C7)6|2Pbm=TM_VzETR;Bzdwo><k26RA+dCW9hS*CCKA
ztJ50%QD4{_@@#Bo#;q}F`>g^xrkK9lg0XAG8cB8`FM;k*dp9o~y6XnXfARzT^63kA
zo(Fb5oC^ifjUm&_l<0<GvuM%gOnStm-b`*hOMQ8M?iu6f?S%u#<jxY~A>LZ>38Xqf
zdgPuKvh#(Ux!cQ}oqKUi)(GI{i=U0S*GWE?gu5Nw%~E#N3+@OGd#=MR$ju#)YazbL
zKwj)??k%|!R2K4`@chx<5;xNT{2?>3q|vy1bqwDsYT8Ga{Vx9M;H!IIE&jRnFVWZD
z{G0cUx88X7@0T9G;U8<?^#03lzigkhV{cvZR`jiP|8DyC@QKC~m!G))#4Xb|y}juj
z=bbetLnou}hMXp+1<kt>t$Wvd;=N1W+j}Z{YVE13PsLB&csg==#p#>Qym@BjnJdn$
ztG<V}uK#cSe^;M<=d5$qe>OUEdL}%xcIK*?Yi4$7C$)O*3T=(H!}A}H<7xK(#p`&N
zd)ND#ean4U`PTd5{*MRN1g;P1p_WiPnm$(dcEjsSr;R@@Th+3;_2}}J%XVPlc=34J
zZi9Snaz@P1?h4Ti5zfqUDt!ic<{h7yahFpn^Ny#{a^4hKXJT}ugh8$*?{C0;A9*b}
zoD6v`DC(7Wj>^5jeX*LfgZR^eGgI1n^WHu3T(cSP*GBxv8N$c^eK<+|snjRoqoc6k
z8?#ZofZ+3T&^T>&d722}G+NT)<gDHjKAC1(yKk0PuRZV5p6Dzu?D+~_f6zQ42KwJ^
zCr~J(;-RhN_ZHK9zRr3iH2Hor?Y`%(Ax@QfKmXhBUReeSiGA7+J~ndcy=zXit=~+W
z5op0~&o+(lr=dPNHE?Zs#^S5DuaFs$@Nk{jle}ak;YDrS%3u(Ff!>#OVJaw4XRZie
zLKjPrF8@_xs*cx$t01Wcfxj<q6v!F{{`Wyr__7quVyU7KQ5gS^lAXgV%x||_gBIXR
t599omRvbnxa2?iH(J{h(Y}Kk`Uq37YfiDFEf!AMOwTb|F0(?p9{{egef-wL9

literal 0
HcmV?d00001

diff --git a/Tests/fonts/LICENSE.txt b/Tests/fonts/LICENSE.txt
index 3c8a23197..94989af90 100644
--- a/Tests/fonts/LICENSE.txt
+++ b/Tests/fonts/LICENSE.txt
@@ -2,7 +2,7 @@
 NotoNastaliqUrdu-Regular.ttf and NotoSansSymbols-Regular.ttf, from https://github.com/googlei18n/noto-fonts
 NotoSans-Regular.ttf, from https://www.google.com/get/noto/
 NotoSansJP-Thin.otf, from https://www.google.com/get/noto/help/cjk/
-AdobeVFPrototype.ttf, from https://github.com/adobe-fonts/adobe-variable-font-prototype
+AdobeVFPrototype.ttf, from https://github.com/adobe-fonts/adobe-variable-font-prototype. AdobeVFPrototypeDuplicates.ttf is a modified version of this
 TINY5x3GX.ttf, from http://velvetyne.fr/fonts/tiny
 ArefRuqaa-Regular.ttf, from https://github.com/google/fonts/tree/master/ofl/arefruqaa
 ter-x20b.pcf, from http://terminus-font.sourceforge.net/
diff --git a/Tests/test_imagefont.py b/Tests/test_imagefont.py
index 39ee9b9c9..d0b458d6b 100644
--- a/Tests/test_imagefont.py
+++ b/Tests/test_imagefont.py
@@ -702,7 +702,7 @@ def test_variation_get(font: ImageFont.FreeTypeFont) -> None:
         font.get_variation_axes()
 
     font = ImageFont.truetype("Tests/fonts/AdobeVFPrototype.ttf")
-    assert font.get_variation_names(), [
+    assert font.get_variation_names() == [
         b"ExtraLight",
         b"Light",
         b"Regular",
@@ -742,6 +742,21 @@ def test_variation_get(font: ImageFont.FreeTypeFont) -> None:
     ]
 
 
+def test_variation_duplicates() -> None:
+    font = ImageFont.truetype("Tests/fonts/AdobeVFPrototypeDuplicates.ttf")
+    assert font.get_variation_names() == [
+        b"ExtraLight",
+        b"Light",
+        b"Regular",
+        b"Semibold",
+        b"Bold",
+        b"Black",
+        b"Black Medium Contrast",
+        b"Black High Contrast",
+        b"Default",
+    ]
+
+
 def _check_text(font: ImageFont.FreeTypeFont, path: str, epsilon: float) -> None:
     im = Image.new("RGB", (100, 75), "white")
     d = ImageDraw.Draw(im)
diff --git a/src/PIL/ImageFont.py b/src/PIL/ImageFont.py
index 2e8ace98d..d11f7bf01 100644
--- a/src/PIL/ImageFont.py
+++ b/src/PIL/ImageFont.py
@@ -675,8 +675,12 @@ class FreeTypeFont:
         :returns: A list of the named styles in a variation font.
         :exception OSError: If the font is not a variation font.
         """
-        names = self.font.getvarnames()
-        return [name.replace(b"\x00", b"") for name in names]
+        names = []
+        for name in self.font.getvarnames():
+            name = name.replace(b"\x00", b"")
+            if name not in names:
+                names.append(name)
+        return names
 
     def set_variation_by_name(self, name: str | bytes) -> None:
         """
diff --git a/src/_imagingft.c b/src/_imagingft.c
index d0af25b30..a371173d6 100644
--- a/src/_imagingft.c
+++ b/src/_imagingft.c
@@ -1287,7 +1287,6 @@ font_getvarnames(FontObject *self) {
                 }
                 PyList_SetItem(list_names, j, list_name);
                 list_names_filled[j] = 1;
-                break;
             }
         }
     }