Commit Graph

11417 Commits

Author SHA1 Message Date
Hugo van Kemenade
5e68a4d895
GHA Windows: Explicitly use cmd shell, as GH changed the defaul… (#4168)
GHA Windows: Explicitly use cmd shell, as GH changed the default to powershell
2019-10-25 16:00:50 +03:00
Hugo
3443c36795 Explicitly use cmd shell, as GHA changed the default to powershell 2019-10-25 14:16:51 +03:00
Hugo van Kemenade
84fed4d213
Use more Pythonic super().__init__() instead of calling parent… (#2198)
Use more Pythonic super().__init__() instead of calling parent class directly
2019-10-23 14:09:02 +03:00
Jon Dufresne
cae17eb927 Use more Pythonic super() instead of referencing parent class
https://rhettinger.wordpress.com/2011/05/26/super-considered-super/
2019-10-22 06:54:58 -07:00
Hugo van Kemenade
1a9be9ccbd
Simpilify PillowTestCase.delete_tempfile for pytest (#4139)
Simpilify PillowTestCase.delete_tempfile for pytest
2019-10-22 14:14:20 +03:00
Andrew Murray
46d1b5a900
Merge pull request #4161 from radarhere/changelog
Updated 6.2.1 release date
2019-10-22 20:42:03 +11:00
Andrew Murray
41a77fcf27 Updated 6.2.1 release date [ci skip] 2019-10-22 20:17:47 +11:00
Andrew Murray
044bdc1370
Merge pull request #4157 from hugovk/update-RELEASING
Add a check for point releases
2019-10-22 19:03:57 +11:00
Christoph Gohlke
2694564d08
Do not destroy glyph while its bitmap is used 2019-10-21 14:47:51 -07:00
Hugo van Kemenade
c4f2c32e2c
Merge pull request #4134 from radarhere/badges
Added GitHub Actions badges for platform builds
2019-10-21 23:50:14 +03:00
Hugo
d8003c350f Add a check for point releases 2019-10-21 21:57:59 +03:00
Hugo van Kemenade
5dcdbfee99
Merge pull request #4154 from hugovk/6.2.1-last-2.7
Pillow 6.2.1 is the last to support Python 2.7
2019-10-21 08:35:46 +03:00
Hugo
a80a45219f Pillow 6.2.1 is the last to support Python 2.7 2019-10-20 23:06:22 +03:00
Hugo van Kemenade
02b02707bc
Add release notes for Pillow 6.2.1 (#4153)
Add release notes for Pillow 6.2.1
2019-10-20 18:26:47 +03:00
Hugo
6f3464e1cb Add release notes for Pillow 6.2.1 2019-10-20 16:31:09 +03:00
Hugo
1bbacf9475 Update CHANGES.rst [CI skip] 2019-10-20 16:13:17 +03:00
Andrew Murray
df86d2d78a
Merge pull request #4150 from radarhere/ci
Updated CI target Python versions for macOS
2019-10-20 21:15:51 +11:00
Andrew Murray
aaf9720c58 Updated CI target Python versions for macOS [ci skip] 2019-10-20 21:00:26 +11:00
Hugo van Kemenade
a56b9713a3
Merge pull request #4141 from hugovk/add-3.8
Add support for Python 3.8
2019-10-20 12:44:04 +03:00
Hugo van Kemenade
2b86210308
Quotes and caps
To exactly match the recommend text at https://tidelift.com/lifter/package/pypi/Pillow/tasks/2439 and hopefully mark the task as done.
2019-10-19 09:58:13 +03:00
hugovk
062c4013a4 Consistent slash 2019-10-15 23:02:43 +03:00
hugovk
fd4707d9d3 Test on Python 3.8 final 2019-10-15 20:57:29 +03:00
Hugo
2ab518edcb Add support for Python 3.8 2019-10-15 12:44:21 +03:00
Hugo van Kemenade
28ff798889
Merge branch 'master' into rm-2.7 2019-10-15 12:11:43 +03:00
Hugo van Kemenade
facd9b003e
Merge pull request #4140 from hugovk/pypy3.6-v7.2.0
Test pypy3.6-v7.2.0 on Windows
2019-10-15 12:06:08 +03:00
hugovk
dcb732d110 Test pypy3.6-v7.2.0 on Windows 2019-10-14 23:22:21 +03:00
Andrew Murray
7068225b23 Updated CHANGES.rst [ci skip] 2019-10-13 08:12:54 +11:00
Andrew Murray
96003a98d0
Merge pull request #4137 from jdufresne/tox-pypy
Add PyPy3 to the tox test matrix
2019-10-13 08:05:43 +11:00
Andrew Murray
02ca4a1a7f
Merge pull request #4138 from jdufresne/skip-known
Remove unused arguments from PillowTestCase.skipKnownBadTest()
2019-10-13 06:42:02 +11:00
Hugo
3dac6e2c62 Replace ImageShow.which() with stdlib
Co-Authored-By: Jon Dufresne <jon.dufresne@gmail.com>
2019-10-12 21:40:11 +03:00
Jon Dufresne
9981568982 Simpilify PillowTestCase.delete_tempfile for pytest
As the test suite always runs with pytest now, self.currentResult is
always None. Using this, can remove unused code.
2019-10-12 11:13:14 -07:00
Jon Dufresne
4cd4adddc3 Improve handling of file resources
Follow Python's file object semantics. User code is responsible for
closing resources (usually through a context manager) in a deterministic
way.

To achieve this, remove __del__ functions. These functions used to
closed open file handlers in an attempt to silence Python
ResourceWarnings. However, using __del__ has the following drawbacks:

- __del__ isn't called until the object's reference count reaches 0.
  Therefore, resource handlers remain open or in use longer than
  necessary.

- The __del__ method isn't guaranteed to execute on system exit. See the
  Python documentation:

  https://docs.python.org/3/reference/datamodel.html#object.__del__

  > It is not guaranteed that __del__() methods are called for objects
  > that still exist when the interpreter exits.

- Exceptions that occur inside __del__ are ignored instead of raised.
  This has the potential of hiding bugs. This is also in the Python
  documentation:

  > Warning: Due to the precarious circumstances under which __del__()
  > methods are invoked, exceptions that occur during their execution
  > are ignored, and a warning is printed to sys.stderr instead.

Instead, always close resource handlers when they are no longer in use.
This will close the file handler at a specified point in the user's code
and not wait until the interpreter chooses to. It is always guaranteed
to run. And, if an exception occurs while closing the file handler, the
bug will not be ignored.

Now, when code receives a ResourceWarning, it will highlight an area
that is mishandling resources. It should not simply be silenced, but
fixed by closing resources with a context manager.

All warnings that were emitted during tests have been cleaned up. To
enable warnings, I passed the `-Wa` CLI option to Python. This exposed
some mishandling of resources in ImageFile.__init__() and
SpiderImagePlugin.loadImageSeries(), they too were fixed.
2019-10-12 08:27:17 -07:00
Jon Dufresne
0affbacd5e Remove unused arguments from PillowTestCase.skipKnwonBadTest() 2019-10-12 08:17:20 -07:00
Jon Dufresne
911079cc68 Add PyPy3 to the tox test matrix
Allows contributors to automatically test locally.
2019-10-12 07:56:43 -07:00
nulano
accbe58b5e add Python version to selftest, rename brief parameter 2019-10-12 15:40:12 +01:00
Hugo
23fa3c6979 Remove outdated OS scripts, point docs to Dockerfiles 2019-10-12 14:16:10 +03:00
Andrew Murray
7c95d9d188
Rearranged badges [ci skip]
Co-Authored-By: Hugo van Kemenade <hugovk@users.noreply.github.com>
2019-10-12 21:53:49 +11:00
Hugo
3e3a73749e Merge remote-tracking branch 'upstream/master' into rm-2.7 2019-10-12 13:42:25 +03:00
Andrew Murray
8cdacf8871 Added GitHub Actions badges for platform builds [ci skip] 2019-10-12 21:38:01 +11:00
Hugo van Kemenade
6595ce1609
Merge pull request #4081 from hugovk/test-with-github-actions
Test Linux and macOS with GitHub Actions
2019-10-12 13:07:28 +03:00
Hugo
a4d7861e34 Turn fail-fast off, so one failed job doesn't cancel others 2019-10-12 12:14:49 +03:00
Hugo
707c9910ab Install OS dependencies without checking version number 2019-10-12 10:49:26 +03:00
Hugo
cf8f8b1743 Drop support for EOL Python 2.7 2019-10-12 10:49:26 +03:00
Hugo
01373b4ed9 Add Codecov token to config 2019-10-12 10:49:26 +03:00
Hugo
ac5642dc76 Split script.sh into build.sh and test.sh 2019-10-12 10:49:26 +03:00
Hugo
7c7c53fbb6 Test macOS with GitHub Actions 2019-10-12 10:49:26 +03:00
Hugo
e595ddbaa1 Test with GitHub Actions 2019-10-12 10:49:26 +03:00
Andrew Murray
4140cd807b
Merge branch 'master' into rm-2.7 2019-10-12 18:03:58 +11:00
Andrew Murray
078a767b77
Merge pull request #4133 from hugovk/dont-test-2.7
CI: Stop testing Python 2.7
2019-10-12 17:56:32 +11:00
Hugo van Kemenade
23c3891b81
Merge pull request #4084 from nulano/gha-win
Test Windows with GitHub Actions
2019-10-11 22:16:45 +03:00