Commit Graph

46 Commits

Author SHA1 Message Date
Hugo
cc63f66575 Merge remote-tracking branch 'upstream/master' into rm-2.7 2019-11-01 13:22:56 +02:00
Jon Dufresne
4cd4adddc3 Improve handling of file resources
Follow Python's file object semantics. User code is responsible for
closing resources (usually through a context manager) in a deterministic
way.

To achieve this, remove __del__ functions. These functions used to
closed open file handlers in an attempt to silence Python
ResourceWarnings. However, using __del__ has the following drawbacks:

- __del__ isn't called until the object's reference count reaches 0.
  Therefore, resource handlers remain open or in use longer than
  necessary.

- The __del__ method isn't guaranteed to execute on system exit. See the
  Python documentation:

  https://docs.python.org/3/reference/datamodel.html#object.__del__

  > It is not guaranteed that __del__() methods are called for objects
  > that still exist when the interpreter exits.

- Exceptions that occur inside __del__ are ignored instead of raised.
  This has the potential of hiding bugs. This is also in the Python
  documentation:

  > Warning: Due to the precarious circumstances under which __del__()
  > methods are invoked, exceptions that occur during their execution
  > are ignored, and a warning is printed to sys.stderr instead.

Instead, always close resource handlers when they are no longer in use.
This will close the file handler at a specified point in the user's code
and not wait until the interpreter chooses to. It is always guaranteed
to run. And, if an exception occurs while closing the file handler, the
bug will not be ignored.

Now, when code receives a ResourceWarning, it will highlight an area
that is mishandling resources. It should not simply be silenced, but
fixed by closing resources with a context manager.

All warnings that were emitted during tests have been cleaned up. To
enable warnings, I passed the `-Wa` CLI option to Python. This exposed
some mishandling of resources in ImageFile.__init__() and
SpiderImagePlugin.loadImageSeries(), they too were fixed.
2019-10-12 08:27:17 -07:00
Hugo
3a34081db5 Simplify temporary directory cleanup
Co-Authored-By: Jon Dufresne <jon.dufresne@gmail.com>
2019-10-08 17:25:55 +03:00
Hugo
538d9e2e5d Upgrade Python syntax with pyupgrade --py3-plus 2019-10-07 14:30:59 +03:00
Jon Dufresne
d50445ff30 Introduce isort to automate import ordering and formatting
Similar to the recent adoption of Black. isort is a Python utility to
sort imports alphabetically and automatically separate into sections. By
using isort, contributors can quickly and automatically conform to the
projects style without thinking. Just let the tool do it.

Uses the configuration recommended by the Black to avoid conflicts of
style.

Rewrite TestImageQt.test_deprecated to no rely on import order.
2019-07-06 16:11:35 -07:00
Hugo
f87821e010 Format with Black 2019-06-13 18:54:11 +03:00
Andrew Murray
ae1f7c4f50 Fixed dimensions of 1-bit PDFs 2019-05-04 16:27:34 +10:00
Jon Dufresne
4de5477b61 Remove unnecessary unittest.main() boilerplate from test files
With the introduction and use of pytest, it is simple and easy to
execute specific tests in isolation through documented command line
arguments. Either by specifying the module path or through the `-k
EXPRESSION` argument. There is no longer any need to provide the
boilerplate:

    if __name__ == '__main__':
        unittest.main()

To every test file. It is simply noise.

The pattern remains in test files that aren't named with `test_*` as
those files are not discovered and executed by pytest by default.
2019-02-03 10:10:16 -08:00
Jon Dufresne
7da17ad41e Improve pytest configuration to allow specific tests as CLI args
The previous test configuration made it difficult to run a single test
with the pytest CLI. There were two major issues:

- The Tests directory was not a package. It now includes a __init__.py
  file and imports from other tests modules are done with relative
  imports.

- setup.cfg always specified the Tests directory. So even if a specific
  test were specified as a CLI arg, this configuration would also always
  include all tests. This configuration has been removed to allow
  specifying a single test on the command line.

Contributors can now run specific tests with a single command such as:

  $ tox -e py37 -- Tests/test_file_pdf.py::TestFilePdf.test_rgb

This makes it easy and faster to iterate on a single test failure and is
very familiar to those that have previously used tox and pytest.

When running tox or pytest with no arguments, they still discover and
runs all tests in the Tests directory.
2019-01-13 09:00:12 -08:00
Andrew Murray
fc57658635 Added PDF creation and modification date info 2018-08-25 00:58:49 +10:00
Andrew Murray
c2189235af Line too long 2018-07-02 19:26:02 +10:00
Andrew Murray
3bbd0a5810 Fixed saving a multiframe image as a single frame PDF 2018-05-18 22:15:45 +10:00
Dvořák Václav
928bea3002 issue #2959: enhance test, mainly to trigger Appveyor re-build 2018-03-04 00:01:14 +01:00
Dvořák Václav
24ecfe315a issue #2959: fix wrong Parent of pre-existing Page objects when appending 2018-03-03 23:32:47 +01:00
Dvořák Václav
c15a0b2fce issue #2959: rename pdfParser.py to PdfParser.py 2018-01-31 00:35:55 +01:00
Dvořák Václav
9be8d669f9 issue #2959: changes based on @hugovk's review 2018-01-31 00:25:04 +01:00
Dvořák Václav
ede57b91e0 issue #2959: keep file open, add context manager, add methods to support writing, eliminate the passing of file or buffer 2018-01-26 19:07:43 +01:00
Dvořák Václav
78fe32a431 issue #2959: support streams, add some tests 2018-01-26 17:15:38 +01:00
Dvořák Václav
53ce9ec4fb issue #2959: fix PdfDict attribute access, text decoding, tests 2018-01-26 13:42:11 +01:00
Dvořák Václav
4d3b13fb08 issue #2959: improve Info setting and dumping 2018-01-26 12:11:10 +01:00
Dvořák Václav
f9566877f3 issue #2959: fix broken test 2018-01-25 01:19:25 +01:00
Dvořák Václav
84f87471f5 issue #2959: support io.BytesIO objects 2018-01-25 00:44:59 +01:00
Dvořák Václav
13fe1a5ba7 issue #2959: text string decoding, support for Info dict, updated tests 2018-01-25 00:20:18 +01:00
Dvořák Václav
cfacf8bff8 issue #2959: fix test for nonexistent PDF file 2018-01-24 02:39:15 +01:00
Dvořák Václav
a187a361cb issue #2959: add tests and fixes, text encoding, remove remnants of text writing from PdfImagePlugin 2018-01-24 02:28:39 +01:00
Dvořák Václav
ba211ff549 issue #2959: pdfParser selftest 2018-01-22 21:35:55 +01:00
wiredfool
52079cb297
Merge pull request #2805 from ixio/fix-#2804
Fix #2804: sets encoderinfo for images when saving multi-page PDF
2017-11-05 15:18:22 +00:00
Andrew Murray
bc255c97ff Added support for generators when using append_images 2017-11-04 10:46:15 +11:00
Ixio
5dfe5f0fa6 Fix #2804 : sets encoderinfo for images when saving multi-page PDF 2017-10-19 13:30:34 +02:00
Andrew Murray
9e843a2d9b Changed format of lambda calls 2017-09-01 21:05:40 +10:00
Andrew Murray
80806d349f Added append_images to PDF saving 2017-05-13 14:26:52 +10:00
homm
1ba4e9e5ba remove end of file banner from all files 2016-07-10 14:11:28 +03:00
Andrew Murray
4e31fb745f Added PDF multipage saving 2015-09-29 22:51:52 +10:00
Andrew Murray
a06b59bd52 Added various tests 2015-07-03 15:03:25 +10:00
hugovk
b929873a62 Change some lena() to hopper() 2014-09-05 12:36:24 +03:00
hugovk
cf04a9a0d2 Remove unused tearDownModule 2014-07-07 20:03:50 +03:00
hugovk
3ec505958e Convert old tests to use unittest 2014-06-10 12:10:47 +03:00
hugovk
8cda5170c8 Fix bytes/str and reinstate test 2014-05-12 14:45:54 +03:00
hugovk
c37aa0a9ca Fix tostring()/tobytes() warning and reinstate test 2014-05-12 14:30:03 +03:00
hugovk
bcb8534dcf Temporarily remove 'failing' 1-mode PDF test 2014-05-11 17:46:13 +03:00
hugovk
741297326a Temporarily remove 'failing' 1-mode PDF test 2014-05-11 17:41:07 +03:00
hugovk
6520004289 Add monochrome PDF test 2014-05-11 17:35:49 +03:00
hugovk
8f1a00ae92 Temporarily remove failing P-mode PDF test 2014-05-11 17:28:41 +03:00
hugovk
3e2ff13aa8 Fix CMYK test 2014-05-11 17:23:10 +03:00
hugovk
c15601e0b0 Add some more pdf tests 2014-05-11 17:16:13 +03:00
hugovk
f165d2034f Simple test for saving to PDF 2014-05-11 09:01:09 +03:00