mirror of
https://github.com/python-pillow/Pillow.git
synced 2024-09-21 19:38:57 +03:00
4cd4adddc3
Follow Python's file object semantics. User code is responsible for closing resources (usually through a context manager) in a deterministic way. To achieve this, remove __del__ functions. These functions used to closed open file handlers in an attempt to silence Python ResourceWarnings. However, using __del__ has the following drawbacks: - __del__ isn't called until the object's reference count reaches 0. Therefore, resource handlers remain open or in use longer than necessary. - The __del__ method isn't guaranteed to execute on system exit. See the Python documentation: https://docs.python.org/3/reference/datamodel.html#object.__del__ > It is not guaranteed that __del__() methods are called for objects > that still exist when the interpreter exits. - Exceptions that occur inside __del__ are ignored instead of raised. This has the potential of hiding bugs. This is also in the Python documentation: > Warning: Due to the precarious circumstances under which __del__() > methods are invoked, exceptions that occur during their execution > are ignored, and a warning is printed to sys.stderr instead. Instead, always close resource handlers when they are no longer in use. This will close the file handler at a specified point in the user's code and not wait until the interpreter chooses to. It is always guaranteed to run. And, if an exception occurs while closing the file handler, the bug will not be ignored. Now, when code receives a ResourceWarning, it will highlight an area that is mishandling resources. It should not simply be silenced, but fixed by closing resources with a context manager. All warnings that were emitted during tests have been cleaned up. To enable warnings, I passed the `-Wa` CLI option to Python. This exposed some mishandling of resources in ImageFile.__init__() and SpiderImagePlugin.loadImageSeries(), they too were fixed.
121 lines
4.1 KiB
Python
121 lines
4.1 KiB
Python
import io
|
|
import sys
|
|
|
|
from PIL import IcnsImagePlugin, Image
|
|
|
|
from .helper import PillowTestCase, unittest
|
|
|
|
# sample icon file
|
|
TEST_FILE = "Tests/images/pillow.icns"
|
|
|
|
enable_jpeg2k = hasattr(Image.core, "jp2klib_version")
|
|
|
|
|
|
class TestFileIcns(PillowTestCase):
|
|
def test_sanity(self):
|
|
# Loading this icon by default should result in the largest size
|
|
# (512x512@2x) being loaded
|
|
with Image.open(TEST_FILE) as im:
|
|
|
|
# Assert that there is no unclosed file warning
|
|
self.assert_warning(None, im.load)
|
|
|
|
self.assertEqual(im.mode, "RGBA")
|
|
self.assertEqual(im.size, (1024, 1024))
|
|
self.assertEqual(im.format, "ICNS")
|
|
|
|
@unittest.skipIf(sys.platform != "darwin", "requires macOS")
|
|
def test_save(self):
|
|
im = Image.open(TEST_FILE)
|
|
|
|
temp_file = self.tempfile("temp.icns")
|
|
im.save(temp_file)
|
|
|
|
reread = Image.open(temp_file)
|
|
|
|
self.assertEqual(reread.mode, "RGBA")
|
|
self.assertEqual(reread.size, (1024, 1024))
|
|
self.assertEqual(reread.format, "ICNS")
|
|
|
|
@unittest.skipIf(sys.platform != "darwin", "requires macOS")
|
|
def test_save_append_images(self):
|
|
im = Image.open(TEST_FILE)
|
|
|
|
temp_file = self.tempfile("temp.icns")
|
|
provided_im = Image.new("RGBA", (32, 32), (255, 0, 0, 128))
|
|
im.save(temp_file, append_images=[provided_im])
|
|
|
|
reread = Image.open(temp_file)
|
|
self.assert_image_similar(reread, im, 1)
|
|
|
|
reread = Image.open(temp_file)
|
|
reread.size = (16, 16, 2)
|
|
reread.load()
|
|
self.assert_image_equal(reread, provided_im)
|
|
|
|
def test_sizes(self):
|
|
# Check that we can load all of the sizes, and that the final pixel
|
|
# dimensions are as expected
|
|
with Image.open(TEST_FILE) as im:
|
|
for w, h, r in im.info["sizes"]:
|
|
wr = w * r
|
|
hr = h * r
|
|
im.size = (w, h, r)
|
|
im.load()
|
|
self.assertEqual(im.mode, "RGBA")
|
|
self.assertEqual(im.size, (wr, hr))
|
|
|
|
# Check that we cannot load an incorrect size
|
|
with self.assertRaises(ValueError):
|
|
im.size = (1, 1)
|
|
|
|
def test_older_icon(self):
|
|
# This icon was made with Icon Composer rather than iconutil; it still
|
|
# uses PNG rather than JP2, however (since it was made on 10.9).
|
|
with Image.open("Tests/images/pillow2.icns") as im:
|
|
for w, h, r in im.info["sizes"]:
|
|
wr = w * r
|
|
hr = h * r
|
|
with Image.open("Tests/images/pillow2.icns") as im2:
|
|
im2.size = (w, h, r)
|
|
im2.load()
|
|
self.assertEqual(im2.mode, "RGBA")
|
|
self.assertEqual(im2.size, (wr, hr))
|
|
|
|
def test_jp2_icon(self):
|
|
# This icon was made by using Uli Kusterer's oldiconutil to replace
|
|
# the PNG images with JPEG 2000 ones. The advantage of doing this is
|
|
# that OS X 10.5 supports JPEG 2000 but not PNG; some commercial
|
|
# software therefore does just this.
|
|
|
|
# (oldiconutil is here: https://github.com/uliwitness/oldiconutil)
|
|
|
|
if not enable_jpeg2k:
|
|
return
|
|
|
|
with Image.open("Tests/images/pillow3.icns") as im:
|
|
for w, h, r in im.info["sizes"]:
|
|
wr = w * r
|
|
hr = h * r
|
|
with Image.open("Tests/images/pillow3.icns") as im2:
|
|
im2.size = (w, h, r)
|
|
im2.load()
|
|
self.assertEqual(im2.mode, "RGBA")
|
|
self.assertEqual(im2.size, (wr, hr))
|
|
|
|
def test_getimage(self):
|
|
with open(TEST_FILE, "rb") as fp:
|
|
icns_file = IcnsImagePlugin.IcnsFile(fp)
|
|
|
|
im = icns_file.getimage()
|
|
self.assertEqual(im.mode, "RGBA")
|
|
self.assertEqual(im.size, (1024, 1024))
|
|
|
|
im = icns_file.getimage((512, 512))
|
|
self.assertEqual(im.mode, "RGBA")
|
|
self.assertEqual(im.size, (512, 512))
|
|
|
|
def test_not_an_icns_file(self):
|
|
with io.BytesIO(b"invalid\n") as fp:
|
|
self.assertRaises(SyntaxError, IcnsImagePlugin.IcnsFile, fp)
|