mirror of
https://github.com/python-pillow/Pillow.git
synced 2024-12-29 11:26:17 +03:00
4cd4adddc3
Follow Python's file object semantics. User code is responsible for closing resources (usually through a context manager) in a deterministic way. To achieve this, remove __del__ functions. These functions used to closed open file handlers in an attempt to silence Python ResourceWarnings. However, using __del__ has the following drawbacks: - __del__ isn't called until the object's reference count reaches 0. Therefore, resource handlers remain open or in use longer than necessary. - The __del__ method isn't guaranteed to execute on system exit. See the Python documentation: https://docs.python.org/3/reference/datamodel.html#object.__del__ > It is not guaranteed that __del__() methods are called for objects > that still exist when the interpreter exits. - Exceptions that occur inside __del__ are ignored instead of raised. This has the potential of hiding bugs. This is also in the Python documentation: > Warning: Due to the precarious circumstances under which __del__() > methods are invoked, exceptions that occur during their execution > are ignored, and a warning is printed to sys.stderr instead. Instead, always close resource handlers when they are no longer in use. This will close the file handler at a specified point in the user's code and not wait until the interpreter chooses to. It is always guaranteed to run. And, if an exception occurs while closing the file handler, the bug will not be ignored. Now, when code receives a ResourceWarning, it will highlight an area that is mishandling resources. It should not simply be silenced, but fixed by closing resources with a context manager. All warnings that were emitted during tests have been cleaned up. To enable warnings, I passed the `-Wa` CLI option to Python. This exposed some mishandling of resources in ImageFile.__init__() and SpiderImagePlugin.loadImageSeries(), they too were fixed.
178 lines
5.4 KiB
Python
178 lines
5.4 KiB
Python
from PIL import Image, WebPImagePlugin
|
|
|
|
from .helper import PillowTestCase, hopper, unittest
|
|
|
|
try:
|
|
from PIL import _webp
|
|
|
|
HAVE_WEBP = True
|
|
except ImportError:
|
|
HAVE_WEBP = False
|
|
|
|
|
|
class TestUnsupportedWebp(PillowTestCase):
|
|
def test_unsupported(self):
|
|
if HAVE_WEBP:
|
|
WebPImagePlugin.SUPPORTED = False
|
|
|
|
file_path = "Tests/images/hopper.webp"
|
|
self.assert_warning(
|
|
UserWarning, lambda: self.assertRaises(IOError, Image.open, file_path)
|
|
)
|
|
|
|
if HAVE_WEBP:
|
|
WebPImagePlugin.SUPPORTED = True
|
|
|
|
|
|
@unittest.skipIf(not HAVE_WEBP, "WebP support not installed")
|
|
class TestFileWebp(PillowTestCase):
|
|
def setUp(self):
|
|
self.rgb_mode = "RGB"
|
|
|
|
def test_version(self):
|
|
_webp.WebPDecoderVersion()
|
|
_webp.WebPDecoderBuggyAlpha()
|
|
|
|
def test_read_rgb(self):
|
|
"""
|
|
Can we read a RGB mode WebP file without error?
|
|
Does it have the bits we expect?
|
|
"""
|
|
|
|
image = Image.open("Tests/images/hopper.webp")
|
|
|
|
self.assertEqual(image.mode, self.rgb_mode)
|
|
self.assertEqual(image.size, (128, 128))
|
|
self.assertEqual(image.format, "WEBP")
|
|
image.load()
|
|
image.getdata()
|
|
|
|
# generated with:
|
|
# dwebp -ppm ../../Tests/images/hopper.webp -o hopper_webp_bits.ppm
|
|
self.assert_image_similar_tofile(
|
|
image, "Tests/images/hopper_webp_bits.ppm", 1.0
|
|
)
|
|
|
|
def test_write_rgb(self):
|
|
"""
|
|
Can we write a RGB mode file to webp without error.
|
|
Does it have the bits we expect?
|
|
"""
|
|
|
|
temp_file = self.tempfile("temp.webp")
|
|
|
|
hopper(self.rgb_mode).save(temp_file)
|
|
image = Image.open(temp_file)
|
|
|
|
self.assertEqual(image.mode, self.rgb_mode)
|
|
self.assertEqual(image.size, (128, 128))
|
|
self.assertEqual(image.format, "WEBP")
|
|
image.load()
|
|
image.getdata()
|
|
|
|
# generated with: dwebp -ppm temp.webp -o hopper_webp_write.ppm
|
|
self.assert_image_similar_tofile(
|
|
image, "Tests/images/hopper_webp_write.ppm", 12.0
|
|
)
|
|
|
|
# This test asserts that the images are similar. If the average pixel
|
|
# difference between the two images is less than the epsilon value,
|
|
# then we're going to accept that it's a reasonable lossy version of
|
|
# the image. The old lena images for WebP are showing ~16 on
|
|
# Ubuntu, the jpegs are showing ~18.
|
|
target = hopper(self.rgb_mode)
|
|
self.assert_image_similar(image, target, 12.0)
|
|
|
|
def test_write_unsupported_mode_L(self):
|
|
"""
|
|
Saving a black-and-white file to WebP format should work, and be
|
|
similar to the original file.
|
|
"""
|
|
|
|
temp_file = self.tempfile("temp.webp")
|
|
hopper("L").save(temp_file)
|
|
image = Image.open(temp_file)
|
|
|
|
self.assertEqual(image.mode, self.rgb_mode)
|
|
self.assertEqual(image.size, (128, 128))
|
|
self.assertEqual(image.format, "WEBP")
|
|
|
|
image.load()
|
|
image.getdata()
|
|
target = hopper("L").convert(self.rgb_mode)
|
|
|
|
self.assert_image_similar(image, target, 10.0)
|
|
|
|
def test_write_unsupported_mode_P(self):
|
|
"""
|
|
Saving a palette-based file to WebP format should work, and be
|
|
similar to the original file.
|
|
"""
|
|
|
|
temp_file = self.tempfile("temp.webp")
|
|
hopper("P").save(temp_file)
|
|
image = Image.open(temp_file)
|
|
|
|
self.assertEqual(image.mode, self.rgb_mode)
|
|
self.assertEqual(image.size, (128, 128))
|
|
self.assertEqual(image.format, "WEBP")
|
|
|
|
image.load()
|
|
image.getdata()
|
|
target = hopper("P").convert(self.rgb_mode)
|
|
|
|
self.assert_image_similar(image, target, 50.0)
|
|
|
|
def test_WebPEncode_with_invalid_args(self):
|
|
"""
|
|
Calling encoder functions with no arguments should result in an error.
|
|
"""
|
|
|
|
if _webp.HAVE_WEBPANIM:
|
|
self.assertRaises(TypeError, _webp.WebPAnimEncoder)
|
|
self.assertRaises(TypeError, _webp.WebPEncode)
|
|
|
|
def test_WebPDecode_with_invalid_args(self):
|
|
"""
|
|
Calling decoder functions with no arguments should result in an error.
|
|
"""
|
|
|
|
if _webp.HAVE_WEBPANIM:
|
|
self.assertRaises(TypeError, _webp.WebPAnimDecoder)
|
|
self.assertRaises(TypeError, _webp.WebPDecode)
|
|
|
|
def test_no_resource_warning(self):
|
|
file_path = "Tests/images/hopper.webp"
|
|
image = Image.open(file_path)
|
|
|
|
temp_file = self.tempfile("temp.webp")
|
|
self.assert_warning(None, image.save, temp_file)
|
|
|
|
def test_file_pointer_could_be_reused(self):
|
|
file_path = "Tests/images/hopper.webp"
|
|
with open(file_path, "rb") as blob:
|
|
Image.open(blob).load()
|
|
Image.open(blob).load()
|
|
|
|
@unittest.skipUnless(
|
|
HAVE_WEBP and _webp.HAVE_WEBPANIM, "WebP save all not available"
|
|
)
|
|
def test_background_from_gif(self):
|
|
with Image.open("Tests/images/chi.gif") as im:
|
|
original_value = im.convert("RGB").getpixel((1, 1))
|
|
|
|
# Save as WEBP
|
|
out_webp = self.tempfile("temp.webp")
|
|
im.save(out_webp, save_all=True)
|
|
|
|
# Save as GIF
|
|
out_gif = self.tempfile("temp.gif")
|
|
Image.open(out_webp).save(out_gif)
|
|
|
|
with Image.open(out_gif) as reread:
|
|
reread_value = reread.convert("RGB").getpixel((1, 1))
|
|
difference = sum(
|
|
[abs(original_value[i] - reread_value[i]) for i in range(0, 3)]
|
|
)
|
|
self.assertLess(difference, 5)
|