reduxjs/redux-devtools
1
1
Fork 0
mirror of https://github.com/reduxjs/redux-devtools.git synced 2024-11-22 09:36:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix uninitialized errorCounts bug in remote DevTools (#936)

Browse Source 
* Fix bug in remote

* Use create instead of connect
This commit is contained in:
Nathan Bierema 2021-11-01 23:19:25 -04:00 committed by GitHub
parent beb02ebe6d
commit 0d38895eb2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/redux-devtools-remote/src/devTools.ts
View File

@ -200,7 +200,7 @@ class DevToolsEnhancer<S, A extends Action<unknown>> {
sendOn: readonly string[] | undefined; sendOn: readonly string[] | undefined;
sendOnError: number | undefined; sendOnError: number | undefined;
channel?: string; channel?: string;
errorCounts?: { [errorName: string]: number }; errorCounts: { [errorName: string]: number } = {};
lastAction?: unknown; lastAction?: unknown;
paused?: boolean; paused?: boolean;
locked?: boolean; locked?: boolean;
@ -423,17 +423,17 @@ class DevToolsEnhancer<S, A extends Action<unknown>> {
) )
return; return;
this.socket = socketCluster.connect(this.socketOptions); this.socket = socketCluster.create(this.socketOptions);
this.socket.on('error', (err) => { this.socket.on('error', (err) => {
// if we've already had this error before, increment it's counter, otherwise assign it '1' since we've had the error once. // if we've already had this error before, increment it's counter, otherwise assign it '1' since we've had the error once.
// eslint-disable-next-line no-prototype-builtins // eslint-disable-next-line no-prototype-builtins
this.errorCounts![err.name] = this.errorCounts!.hasOwnProperty(err.name) this.errorCounts[err.name] = this.errorCounts.hasOwnProperty(err.name)
? this.errorCounts![err.name] + 1 ? this.errorCounts[err.name] + 1
: 1; : 1;
if (this.suppressConnectErrors) { if (this.suppressConnectErrors) {
if (this.errorCounts![err.name] === 1) { if (this.errorCounts[err.name] === 1) {
console.log( console.log(
'remote-redux-devtools: Socket connection errors are being suppressed. ' + 'remote-redux-devtools: Socket connection errors are being suppressed. ' +
'\n' + '\n' +