Merge pull request #133 from gaearon/optimize-state-computation

Do not recompute states unless necessary

src/devTools.js

@@ -95,6 +95,7 @@ function liftReducer(reducer, initialState) {
    * Manages how the DevTools actions modify the DevTools state.
    */
   return function liftedReducer(liftedState = initialLiftedState, liftedAction) {
+    let shouldRecomputeStates = true;
     let {
       committedState,
       stagedActions,
@@ -131,6 +132,8 @@ function liftReducer(reducer, initialState) {
       break;
     case ActionTypes.JUMP_TO_STATE:
       currentStateIndex = liftedAction.index;
+      // Optimization: we know the history has not changed.
+      shouldRecomputeStates = false;
       break;
     case ActionTypes.SWEEP:
       stagedActions = stagedActions.filter((_, i) => !skippedActions[i]);
@@ -142,8 +145,21 @@ function liftReducer(reducer, initialState) {
       if (currentStateIndex === stagedActions.length - 1) {
         currentStateIndex++;
       }
+
       stagedActions = [...stagedActions, liftedAction.action];
       timestamps = [...timestamps, liftedAction.timestamp];
+
+      // Optimization: we know that the past has not changed.
+      shouldRecomputeStates = false;
+      // Instead of recomputing the states, append the next one.
+      const previousEntry = computedStates[computedStates.length - 1];
+      const nextEntry = computeNextEntry(
+        reducer,
+        liftedAction.action,
+        previousEntry.state,
+        previousEntry.error
+      );
+      computedStates = [...computedStates, nextEntry];
       break;
     case ActionTypes.SET_MONITOR_STATE:
       monitorState = liftedAction.monitorState;
@@ -159,12 +175,14 @@ function liftReducer(reducer, initialState) {
       break;
     }
 
-    computedStates = recomputeStates(
+    if (shouldRecomputeStates) {
-      reducer,
+      computedStates = recomputeStates(
-      committedState,
+        reducer,
-      stagedActions,
+        committedState,
-      skippedActions
+        stagedActions,
-    );
+        skippedActions
+      );
+    }
 
     return {
       committedState,

test/devTools.spec.js

@@ -212,4 +212,35 @@ describe('devTools', () => {
     storeWithBug.dispatch({ type: 'SET_UNDEFINED' });
     expect(storeWithBug.getState()).toBe(2);
   });
+
+  it('should not recompute states on every action', () => {
+    let reducerCalls = 0;
+    let monitoredStore = devTools()(createStore)(() => reducerCalls++);
+    expect(reducerCalls).toBe(1);
+    monitoredStore.dispatch({ type: 'INCREMENT' });
+    monitoredStore.dispatch({ type: 'INCREMENT' });
+    monitoredStore.dispatch({ type: 'INCREMENT' });
+    expect(reducerCalls).toBe(4);
+  });
+
+  it('should not recompute states when jumping to state', () => {
+    let reducerCalls = 0;
+    let monitoredStore = devTools()(createStore)(() => reducerCalls++);
+    let monitoredDevToolsStore = monitoredStore.devToolsStore;
+
+    expect(reducerCalls).toBe(1);
+    monitoredStore.dispatch({ type: 'INCREMENT' });
+    monitoredStore.dispatch({ type: 'INCREMENT' });
+    monitoredStore.dispatch({ type: 'INCREMENT' });
+    expect(reducerCalls).toBe(4);
+
+    monitoredDevToolsStore.dispatch(ActionCreators.jumpToState(0));
+    expect(reducerCalls).toBe(4);
+
+    monitoredDevToolsStore.dispatch(ActionCreators.jumpToState(1));
+    expect(reducerCalls).toBe(4);
+
+    monitoredDevToolsStore.dispatch(ActionCreators.jumpToState(3));
+    expect(reducerCalls).toBe(4);
+  });
 });