reduxjs/redux-devtools
1
1
Fork 0
mirror of https://github.com/reduxjs/redux-devtools.git synced 2025-01-31 11:51:41 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove console logs in production

Browse Source
This commit is contained in:
Zalmoxisus 2018-12-12 22:45:37 +02:00
parent bc3234253c
commit 6e117be436
3 changed files with 22 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/redux-devtools-trace-monitor/.eslintrc
View File

@ -24,7 +24,7 @@
"react/jsx-quotes": 0,
"eol-last": 0,
"no-unused-vars": 0,
"no-console": 0,
"no-console": 1,
"comma-dangle": 0
},
"plugins": [

38
packages/redux-devtools-trace-monitor/src/StackTraceTab.js
View File

@ -12,7 +12,7 @@ export default class StackTraceTab extends Component {
};
}
componentDidMount() {
//console.log("StackTraceTab mounted");
// console.log("StackTraceTab mounted");
this.checkForStackTrace();
}
@ -38,10 +38,12 @@ export default class StackTraceTab extends Component {
const deserializedError = Object.assign(new Error(), {stack: liftedAction.stack});
getStackFrames(deserializedError)
.then(stackFrames => {
console.log('Stack frames: ', stackFrames);
this.setState({stackFrames, currentError: deserializedError});
});
.then(stackFrames => {
/* eslint-disable no-console */
if (process.env.NODE_ENV === 'development') console.log('Stack frames: ', stackFrames);
/* eslint-enable no-console */
this.setState({stackFrames, currentError: deserializedError});
});
}
else {
this.setState({stackFrames: []});
@ -49,38 +51,38 @@ export default class StackTraceTab extends Component {
}
onStackLocationClicked = (fileLocation = {}) => {
//console.log("Stack location args: ", ...args);
// console.log("Stack location args: ", ...args);
const {fileName, lineNumber} = fileLocation;
if(fileName && lineNumber) {
const matchingStackFrame = this.state.stackFrames.find(stackFrame => {
const matches = (
(stackFrame._originalFileName === fileName && stackFrame._originalLineNumber === lineNumber) ||
(stackFrame.fileName === fileName && stackFrame.lineNumber === lineNumber)
);
(stackFrame._originalFileName === fileName && stackFrame._originalLineNumber === lineNumber) ||
(stackFrame.fileName === fileName && stackFrame.lineNumber === lineNumber)
);
return matches;
});
//console.log("Matching stack frame: ", matchingStackFrame);
// console.log("Matching stack frame: ", matchingStackFrame);
if(matchingStackFrame) {
/*
const frameIndex = this.state.stackFrames.indexOf(matchingStackFrame);
const originalStackFrame = parsedFramesNoSourcemaps[frameIndex];
console.log("Original stack frame: ", originalStackFrame);
*/
/*
const frameIndex = this.state.stackFrames.indexOf(matchingStackFrame);
const originalStackFrame = parsedFramesNoSourcemaps[frameIndex];
console.log("Original stack frame: ", originalStackFrame);
*/
const adjustedLineNumber = Math.max(lineNumber - 1, 0);
chrome.devtools.panels.openResource(fileName, adjustedLineNumber, (result) => {
//console.log("openResource callback args: ", callbackArgs);
//console.log("Testing");
//console.log("openResource callback args: ", callbackArgs);
//console.log("Testing");
if(result.isError) {
const {fileName: finalFileName, lineNumber: finalLineNumber} = matchingStackFrame;
const adjustedLineNumber = Math.max(finalLineNumber - 1, 0);
chrome.devtools.panels.openResource(finalFileName, adjustedLineNumber, (result) => {
//console.log("openResource result: ", result);
// console.log("openResource result: ", result);
});
}
});

2
packages/redux-devtools-trace-monitor/src/react-error-overlay/utils/generateAnsiHTML.js vendored
View File

@ -86,7 +86,7 @@ function generateAnsiHTML(txt: string): string {
result += '<span style="color: #' + color + ';">' + part + '</span>';
} else {
if (fg != null) {
console.log('Missing color mapping: ', fg);
console.log('Missing color mapping:', fg); // eslint-disable-line no-console
}
result += '<span>' + part + '</span>';
}