From 8926238b35cee3d989df45978c0e04619484129e Mon Sep 17 00:00:00 2001 From: Nathan Bierema Date: Sun, 12 Jun 2022 20:56:18 -0400 Subject: [PATCH] stash --- .../redux-devtools-app/src/middlewares/api.ts | 3 +-- .../redux-devtools-cli/src/bin/redux-devtools.ts | 8 ++------ packages/redux-devtools-cli/src/index.ts | 15 +++++++-------- 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/packages/redux-devtools-app/src/middlewares/api.ts b/packages/redux-devtools-app/src/middlewares/api.ts index 22ff1fc2..ebdb32fd 100644 --- a/packages/redux-devtools-app/src/middlewares/api.ts +++ b/packages/redux-devtools-app/src/middlewares/api.ts @@ -167,8 +167,7 @@ function handleConnection() { authState: socket.authState, socketState: socket.state, }, - // TODO Fix - // @ts-expect-error Because + // @ts-expect-error Is this legitimate? error: data.authError, }); if (socket.authState !== actions.AUTHENTICATED) { diff --git a/packages/redux-devtools-cli/src/bin/redux-devtools.ts b/packages/redux-devtools-cli/src/bin/redux-devtools.ts index 3c0ff949..74ce0166 100644 --- a/packages/redux-devtools-cli/src/bin/redux-devtools.ts +++ b/packages/redux-devtools-cli/src/bin/redux-devtools.ts @@ -90,11 +90,7 @@ if (argv.injectserver) { // eslint-disable-next-line @typescript-eslint/no-floating-promises server(argv).then(async function (r) { if (argv.open && argv.open !== 'false') { - await r - .listener('ready') - .once() - .then(async () => { - await openApp(argv.open as string, options); - }); + await r.listener('ready').once(); + await openApp(argv.open as string, options); } }); diff --git a/packages/redux-devtools-cli/src/index.ts b/packages/redux-devtools-cli/src/index.ts index 6ccddf13..b94b58a0 100644 --- a/packages/redux-devtools-cli/src/index.ts +++ b/packages/redux-devtools-cli/src/index.ts @@ -17,7 +17,7 @@ export interface ExtendedOptions extends Options { export default function (argv: { [arg: string]: any }): Promise<{ portAlreadyUsed?: boolean; - listener: (eventName: 'ready') => { once(): Promise }; + listener: (eventName: 'ready') => { once(): Promise }; }> { const options = Object.assign(getOptions(argv), { allowClientPublish: false, @@ -135,19 +135,18 @@ export default function (argv: { [arg: string]: any }): Promise<{ for await (const data of socket.receiver('disconnect')) { const channel = agServer.exchange.channel('sc-' + socket.id); channel.unsubscribe(); - // TODO - // void agServer.exchange.transmitPublish(channelToEmit, { - // id: socket.id, - // type: 'DISCONNECTED', - // }); + // eslint-disable-next-line @typescript-eslint/no-non-null-assertion + void agServer.exchange.transmitPublish(channelToEmit!, { + id: socket.id, + type: 'DISCONNECTED', + }); } })(); } })(); httpServer.listen(options.port); - // TODO Fix - // @ts-expect-error Because + // @ts-expect-error Shouldn't there be a 'ready' event? resolve(agServer); } /* eslint-enable no-console */