From a3ba875560c1cc26f41d77f5d18b89f02fda02ef Mon Sep 17 00:00:00 2001 From: Nathan Bierema Date: Mon, 2 Jan 2023 14:05:24 -0500 Subject: [PATCH] Fix empty arrays --- .changeset/spicy-olives-compete.md | 12 ++++++------ .changeset/weak-kings-brake.md | 2 +- packages/d3-state-visualizer/src/charts/tree/tree.ts | 8 +++++--- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/.changeset/spicy-olives-compete.md b/.changeset/spicy-olives-compete.md index b37bc8e8..3ac8e9a7 100644 --- a/.changeset/spicy-olives-compete.md +++ b/.changeset/spicy-olives-compete.md @@ -2,9 +2,9 @@ 'd3tooltip': major --- -- Remove UMD build -- Upgrade d3 peer dependency from v3 to v4 -- Remove `attr` configuration method -- Rename `style` configuration method to `styles` and move to options -- Move `text` configuration method to options -- Remove d3 parameter as first parameter for `tooltip` +- Remove UMD build. +- Upgrade d3 peer dependency from v3 to v4. +- Remove `attr` configuration method. +- Rename `style` configuration method to `styles` and move to options. +- Move `text` configuration method to options. +- Remove d3 parameter as first parameter for `tooltip`. diff --git a/.changeset/weak-kings-brake.md b/.changeset/weak-kings-brake.md index ce94f67d..3f6b4107 100644 --- a/.changeset/weak-kings-brake.md +++ b/.changeset/weak-kings-brake.md @@ -2,4 +2,4 @@ 'map2tree': major --- -Remove UMD build +- Remove UMD build. diff --git a/packages/d3-state-visualizer/src/charts/tree/tree.ts b/packages/d3-state-visualizer/src/charts/tree/tree.ts index 130cd7e1..3522702c 100644 --- a/packages/d3-state-visualizer/src/charts/tree/tree.ts +++ b/packages/d3-state-visualizer/src/charts/tree/tree.ts @@ -396,9 +396,9 @@ export default function (DOMNode: HTMLElement, options: Partial = {}) { .style('stroke', 'black') .style('stroke-width', '1.5px') .style('fill', (d) => - d.data._children + d.data._children && d.data._children.length > 0 ? nodeStyleOptions.colors.collapsed - : d.data.children + : d.data.children && d.data.children.length > 0 ? nodeStyleOptions.colors.parent : nodeStyleOptions.colors.default ); @@ -418,7 +418,9 @@ export default function (DOMNode: HTMLElement, options: Partial = {}) { .style('fill-opacity', 1) .attr('transform', function transform(d) { const x = - (d.data.children || d.data._children ? -1 : 1) * + (((d.data.children ?? d.data._children)?.length ?? 0) > 0 + ? -1 + : 1) * (this.getBBox().width / 2 + nodeStyleOptions.radius + 5); return `translate(${x},0)`; });