From abd03a70c7f1563c577350c636b844f1ad8d3d66 Mon Sep 17 00:00:00 2001
From: Nathan Bierema <nbierema@gmail.com>
Date: Fri, 30 Aug 2024 23:26:39 -0400
Subject: [PATCH] Fix: only send data to extension if DevTools are open (#1735)

* Fix: only send data to extension if DevTools are open

* Create odd-apples-argue.md
---
 .changeset/odd-apples-argue.md                |  5 +++++
 .../src/background/store/apiMiddleware.ts     | 20 +++++++------------
 2 files changed, 12 insertions(+), 13 deletions(-)
 create mode 100644 .changeset/odd-apples-argue.md

diff --git a/.changeset/odd-apples-argue.md b/.changeset/odd-apples-argue.md
new file mode 100644
index 00000000..79e05292
--- /dev/null
+++ b/.changeset/odd-apples-argue.md
@@ -0,0 +1,5 @@
+---
+'remotedev-redux-devtools-extension': patch
+---
+
+Fix: only send data to extension if DevTools are open
diff --git a/extension/src/background/store/apiMiddleware.ts b/extension/src/background/store/apiMiddleware.ts
index 7f24e0af..be7ba34f 100644
--- a/extension/src/background/store/apiMiddleware.ts
+++ b/extension/src/background/store/apiMiddleware.ts
@@ -249,6 +249,7 @@ const chunks: {
   >;
 } = {};
 let monitors = 0;
+let isMonitored = false;
 
 const getId = (sender: chrome.runtime.MessageSender, name?: string) =>
   sender.tab ? sender.tab.id! : name || sender.id!;
@@ -262,12 +263,7 @@ type MonitorAction<S, A extends Action<string>> =
 // Chrome message limit is 64 MB, but we're using 32 MB to include other object's parts
 const maxChromeMsgSize = 32 * 1024 * 1024;
 
-// TODO Clean up args
-function toMonitors<S, A extends Action<string>>(
-  action: MonitorAction<S, A>,
-  tabId?: string | number,
-  verbose?: boolean,
-) {
+function toMonitors<S, A extends Action<string>>(action: MonitorAction<S, A>) {
   for (const port of [
     ...Object.values(connections.monitor),
     ...Object.values(connections.panel),
@@ -417,6 +413,7 @@ function toAllTabs(msg: TabMessage) {
 }
 
 function monitorInstances(shouldMonitor: boolean, id?: string) {
+  if (!id && isMonitored === shouldMonitor) return;
   const action = {
     type: shouldMonitor ? ('START' as const) : ('STOP' as const),
   };
@@ -425,6 +422,7 @@ function monitorInstances(shouldMonitor: boolean, id?: string) {
   } else {
     toAllTabs(action);
   }
+  isMonitored = shouldMonitor;
 }
 
 function getReducerError() {
@@ -499,7 +497,7 @@ function messaging<S, A extends Action<string>>(
   }
   if (request.type === 'ERROR') {
     if (request.payload) {
-      toMonitors(request, tabId);
+      toMonitors(request);
       return;
     }
     if (!request.message) return;
@@ -541,11 +539,7 @@ function messaging<S, A extends Action<string>>(
   }
   store.dispatch(action);
 
-  if (request.type === 'EXPORT') {
-    toMonitors(action, tabId, true);
-  } else {
-    toMonitors(action, tabId);
-  }
+  toMonitors(action);
 }
 
 function disconnect(
@@ -587,7 +581,7 @@ function onConnect<S, A extends Action<string>>(port: chrome.runtime.Port) {
           chrome.action.enable(id);
           chrome.action.setIcon({ tabId: id, path: 'img/logo/38x38.png' });
         }
-        port.postMessage({ type: 'START' });
+        if (isMonitored) port.postMessage({ type: 'START' });
 
         const state = store.getState();
         if (state.instances.persisted) {