reduxjs/redux-devtools
1
1
Fork 0
mirror of https://github.com/reduxjs/redux-devtools.git synced 2024-11-10 19:56:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

Warn and do not attempt to render if store not instrumented

Browse Source 
Very confusing error messages were produced if the
container component returned by createDevTools()
was constructed without a store being injected or
if the store had not been instrumented with
DevTools.instrument()

Add warnings for both of these cases and avoid console error
spam by short circuiting rendering of the devtools if they
have not been setup correctly.

Fixes #179
This commit is contained in:
Robert Knight 2015-12-26 23:45:02 +00:00
parent 23d99f974a
commit afb3b8b5a1
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/createDevTools.js
View File

@ -24,14 +24,32 @@ export default function createDevTools(children) {
constructor(props, context) {
super(props, context);
if (!props.store && !context.store) {
console.error(
`DevTools cannot render because no Redux store was injected via \
props or <Provide>`);
return;
}
if (context.store) {
this.liftedStore = context.store.liftedStore;
} else {
this.liftedStore = props.store.liftedStore;
}
if (!this.liftedStore) {
console.error(
`DevTools cannot render because the store not been instrumented \
with DevTools.instrument()`);
}
}
render() {
if (!this.liftedStore) {
return null;
}
return (
<ConnectedMonitor {...monitorProps}
store={this.liftedStore} />
@ -39,4 +57,3 @@ export default function createDevTools(children) {
}
};
}