From b79b2c3bbc2bbc3685f1d5c78f05e9eca05637a3 Mon Sep 17 00:00:00 2001 From: Nathan Bierema Date: Sun, 17 Dec 2023 22:03:02 -0500 Subject: [PATCH] Fix some unbound-method ESLint errors (#1576) * Fix some unbound-method ESLint errors * Keep that one --- .../src/components/TopButtons.tsx | 1 - .../src/containers/DevTools.tsx | 2 +- .../src/ChartMonitor.tsx | 2 +- .../src/DevtoolsInspector.tsx | 6 ----- .../src/instrument.ts | 27 ++++++++++++------- .../src/LogMonitor.tsx | 1 - .../src/LogMonitorButtonBar.tsx | 1 - .../todomvc/src/actions/TodoActions.ts | 12 ++++----- .../todomvc/src/components/MainSection.tsx | 1 - .../todomvc/src/containers/TodoApp.tsx | 1 - .../src/SliderMonitor.tsx | 1 - .../todomvc/src/actions/TodoActions.ts | 12 ++++----- .../todomvc/src/components/MainSection.tsx | 1 - .../todomvc/src/containers/TodoApp.tsx | 1 - 14 files changed, 31 insertions(+), 38 deletions(-) diff --git a/packages/redux-devtools-app/src/components/TopButtons.tsx b/packages/redux-devtools-app/src/components/TopButtons.tsx index 5f5d3d7e..d27fbeec 100644 --- a/packages/redux-devtools-app/src/components/TopButtons.tsx +++ b/packages/redux-devtools-app/src/components/TopButtons.tsx @@ -9,7 +9,6 @@ import InstanceSelector from './InstanceSelector'; import SyncButton from './buttons/SyncButton'; import { Options, State } from '../reducers/instances'; -// eslint-disable-next-line @typescript-eslint/unbound-method const { reset, rollback, commit, sweep } = ActionCreators; interface Props { diff --git a/packages/redux-devtools-app/src/containers/DevTools.tsx b/packages/redux-devtools-app/src/containers/DevTools.tsx index db197332..abebcec6 100644 --- a/packages/redux-devtools-app/src/containers/DevTools.tsx +++ b/packages/redux-devtools-app/src/containers/DevTools.tsx @@ -27,6 +27,7 @@ class DevTools extends Component { LiftedState, unknown> > & { update( + this: void, monitorProps: unknown, state: unknown | undefined, action: Action, @@ -44,7 +45,6 @@ class DevTools extends Component { this.monitorProps = monitorElement.props; this.Monitor = monitorElement.type; - // eslint-disable-next-line @typescript-eslint/unbound-method const update = this.Monitor!.update; if (update) { let newMonitorState; diff --git a/packages/redux-devtools-chart-monitor/src/ChartMonitor.tsx b/packages/redux-devtools-chart-monitor/src/ChartMonitor.tsx index 3dfa389c..27004292 100644 --- a/packages/redux-devtools-chart-monitor/src/ChartMonitor.tsx +++ b/packages/redux-devtools-chart-monitor/src/ChartMonitor.tsx @@ -11,7 +11,7 @@ import type { Options } from 'd3-state-visualizer'; import reducer, { ChartMonitorState } from './reducers'; import Chart, { Props } from './Chart'; -// eslint-disable-next-line @typescript-eslint/unbound-method + const { reset, rollback, commit, sweep, toggleAction } = ActionCreators; const styles: { container: CSSProperties } = { diff --git a/packages/redux-devtools-inspector-monitor/src/DevtoolsInspector.tsx b/packages/redux-devtools-inspector-monitor/src/DevtoolsInspector.tsx index 7e788c21..a2914ec4 100644 --- a/packages/redux-devtools-inspector-monitor/src/DevtoolsInspector.tsx +++ b/packages/redux-devtools-inspector-monitor/src/DevtoolsInspector.tsx @@ -25,17 +25,11 @@ import { import { ThemeProvider } from '@emotion/react'; const { - // eslint-disable-next-line @typescript-eslint/unbound-method commit, - // eslint-disable-next-line @typescript-eslint/unbound-method sweep, - // eslint-disable-next-line @typescript-eslint/unbound-method toggleAction, - // eslint-disable-next-line @typescript-eslint/unbound-method jumpToAction, - // eslint-disable-next-line @typescript-eslint/unbound-method jumpToState, - // eslint-disable-next-line @typescript-eslint/unbound-method reorderAction, } = ActionCreators; diff --git a/packages/redux-devtools-instrument/src/instrument.ts b/packages/redux-devtools-instrument/src/instrument.ts index f88b09eb..3f1ff7e4 100644 --- a/packages/redux-devtools-instrument/src/instrument.ts +++ b/packages/redux-devtools-instrument/src/instrument.ts @@ -133,6 +133,7 @@ export type LiftedAction, MonitorState> = */ export const ActionCreators = { performAction>( + this: void, action: A, trace?: ((action: A) => string | undefined) | boolean, traceLimit?: number, @@ -203,27 +204,28 @@ export const ActionCreators = { }; }, - reset(): ResetAction { + reset(this: void): ResetAction { return { type: ActionTypes.RESET, timestamp: Date.now() }; }, - rollback(): RollbackAction { + rollback(this: void): RollbackAction { return { type: ActionTypes.ROLLBACK, timestamp: Date.now() }; }, - commit(): CommitAction { + commit(this: void): CommitAction { return { type: ActionTypes.COMMIT, timestamp: Date.now() }; }, - sweep(): SweepAction { + sweep(this: void): SweepAction { return { type: ActionTypes.SWEEP }; }, - toggleAction(id: number): ToggleAction { + toggleAction(this: void, id: number): ToggleAction { return { type: ActionTypes.TOGGLE_ACTION, id }; }, setActionsActive( + this: void, start: number, end: number, active = true, @@ -231,30 +233,35 @@ export const ActionCreators = { return { type: ActionTypes.SET_ACTIONS_ACTIVE, start, end, active }; }, - reorderAction(actionId: number, beforeActionId: number): ReorderAction { + reorderAction( + this: void, + actionId: number, + beforeActionId: number, + ): ReorderAction { return { type: ActionTypes.REORDER_ACTION, actionId, beforeActionId }; }, - jumpToState(index: number): JumpToStateAction { + jumpToState(this: void, index: number): JumpToStateAction { return { type: ActionTypes.JUMP_TO_STATE, index }; }, - jumpToAction(actionId: number): JumpToActionAction { + jumpToAction(this: void, actionId: number): JumpToActionAction { return { type: ActionTypes.JUMP_TO_ACTION, actionId }; }, importState, MonitorState = null>( + this: void, nextLiftedState: LiftedState | readonly A[], noRecompute?: boolean, ): ImportStateAction { return { type: ActionTypes.IMPORT_STATE, nextLiftedState, noRecompute }; }, - lockChanges(status: boolean): LockChangesAction { + lockChanges(this: void, status: boolean): LockChangesAction { return { type: ActionTypes.LOCK_CHANGES, status }; }, - pauseRecording(status: boolean): PauseRecordingAction { + pauseRecording(this: void, status: boolean): PauseRecordingAction { return { type: ActionTypes.PAUSE_RECORDING, status }; }, }; diff --git a/packages/redux-devtools-log-monitor/src/LogMonitor.tsx b/packages/redux-devtools-log-monitor/src/LogMonitor.tsx index 6b1d34dd..a9082bef 100644 --- a/packages/redux-devtools-log-monitor/src/LogMonitor.tsx +++ b/packages/redux-devtools-log-monitor/src/LogMonitor.tsx @@ -17,7 +17,6 @@ import reducer, { LogMonitorState } from './reducers'; import LogMonitorButtonBar from './LogMonitorButtonBar'; import LogMonitorEntryList from './LogMonitorEntryList'; -// eslint-disable-next-line @typescript-eslint/unbound-method const { toggleAction, setActionsActive } = ActionCreators; const styles: { diff --git a/packages/redux-devtools-log-monitor/src/LogMonitorButtonBar.tsx b/packages/redux-devtools-log-monitor/src/LogMonitorButtonBar.tsx index 9753977f..551b8894 100644 --- a/packages/redux-devtools-log-monitor/src/LogMonitorButtonBar.tsx +++ b/packages/redux-devtools-log-monitor/src/LogMonitorButtonBar.tsx @@ -6,7 +6,6 @@ import LogMonitorButton from './LogMonitorButton'; import { LogMonitorAction } from './actions'; import { LogMonitorState } from './reducers'; -// eslint-disable-next-line @typescript-eslint/unbound-method const { reset, rollback, commit, sweep } = ActionCreators; const style: CSSProperties = { diff --git a/packages/redux-devtools-slider-monitor/examples/todomvc/src/actions/TodoActions.ts b/packages/redux-devtools-slider-monitor/examples/todomvc/src/actions/TodoActions.ts index 4169e9c1..ba4d40cf 100644 --- a/packages/redux-devtools-slider-monitor/examples/todomvc/src/actions/TodoActions.ts +++ b/packages/redux-devtools-slider-monitor/examples/todomvc/src/actions/TodoActions.ts @@ -73,10 +73,10 @@ export type TodoAction = | ClearMarkedAction; export interface TodoActions { - addTodo(text: string): AddTodoAction; - deleteTodo(id: number): DeleteTodoAction; - editTodo(id: number, text: string): EditTodoAction; - markTodo(id: number): MarkTodoAction; - markAll(): MarkAllAction; - clearMarked(): ClearMarkedAction; + addTodo(this: void, text: string): AddTodoAction; + deleteTodo(this: void, id: number): DeleteTodoAction; + editTodo(this: void, id: number, text: string): EditTodoAction; + markTodo(this: void, id: number): MarkTodoAction; + markAll(this: void): MarkAllAction; + clearMarked(this: void): ClearMarkedAction; } diff --git a/packages/redux-devtools-slider-monitor/examples/todomvc/src/components/MainSection.tsx b/packages/redux-devtools-slider-monitor/examples/todomvc/src/components/MainSection.tsx index 4abeaf49..199f1bac 100644 --- a/packages/redux-devtools-slider-monitor/examples/todomvc/src/components/MainSection.tsx +++ b/packages/redux-devtools-slider-monitor/examples/todomvc/src/components/MainSection.tsx @@ -70,7 +70,6 @@ export default class MainSection extends Component { className="toggle-all" type="checkbox" checked={markedCount === todos.length} - // eslint-disable-next-line @typescript-eslint/unbound-method onChange={actions.markAll} /> ); diff --git a/packages/redux-devtools-slider-monitor/examples/todomvc/src/containers/TodoApp.tsx b/packages/redux-devtools-slider-monitor/examples/todomvc/src/containers/TodoApp.tsx index f8f3ed49..3a95b150 100644 --- a/packages/redux-devtools-slider-monitor/examples/todomvc/src/containers/TodoApp.tsx +++ b/packages/redux-devtools-slider-monitor/examples/todomvc/src/containers/TodoApp.tsx @@ -18,7 +18,6 @@ interface Props { const TodoApp: FunctionComponent = ({ todos, actions }) => (
- {/* eslint-disable-next-line @typescript-eslint/unbound-method */}
diff --git a/packages/redux-devtools-slider-monitor/src/SliderMonitor.tsx b/packages/redux-devtools-slider-monitor/src/SliderMonitor.tsx index 8cf47bba..20ebe299 100644 --- a/packages/redux-devtools-slider-monitor/src/SliderMonitor.tsx +++ b/packages/redux-devtools-slider-monitor/src/SliderMonitor.tsx @@ -18,7 +18,6 @@ import { import reducer from './reducers'; import SliderButton from './SliderButton'; -// eslint-disable-next-line @typescript-eslint/unbound-method const { reset, jumpToAction } = ActionCreators; interface ExternalProps> { diff --git a/packages/redux-devtools/examples/todomvc/src/actions/TodoActions.ts b/packages/redux-devtools/examples/todomvc/src/actions/TodoActions.ts index 4169e9c1..ba4d40cf 100644 --- a/packages/redux-devtools/examples/todomvc/src/actions/TodoActions.ts +++ b/packages/redux-devtools/examples/todomvc/src/actions/TodoActions.ts @@ -73,10 +73,10 @@ export type TodoAction = | ClearMarkedAction; export interface TodoActions { - addTodo(text: string): AddTodoAction; - deleteTodo(id: number): DeleteTodoAction; - editTodo(id: number, text: string): EditTodoAction; - markTodo(id: number): MarkTodoAction; - markAll(): MarkAllAction; - clearMarked(): ClearMarkedAction; + addTodo(this: void, text: string): AddTodoAction; + deleteTodo(this: void, id: number): DeleteTodoAction; + editTodo(this: void, id: number, text: string): EditTodoAction; + markTodo(this: void, id: number): MarkTodoAction; + markAll(this: void): MarkAllAction; + clearMarked(this: void): ClearMarkedAction; } diff --git a/packages/redux-devtools/examples/todomvc/src/components/MainSection.tsx b/packages/redux-devtools/examples/todomvc/src/components/MainSection.tsx index eb51c23f..37f0704b 100644 --- a/packages/redux-devtools/examples/todomvc/src/components/MainSection.tsx +++ b/packages/redux-devtools/examples/todomvc/src/components/MainSection.tsx @@ -77,7 +77,6 @@ export default class MainSection extends Component { className="toggle-all" type="checkbox" checked={markedCount === todos.length} - // eslint-disable-next-line @typescript-eslint/unbound-method onChange={actions.markAll} /> diff --git a/packages/redux-devtools/examples/todomvc/src/containers/TodoApp.tsx b/packages/redux-devtools/examples/todomvc/src/containers/TodoApp.tsx index c225553c..b5a2b94f 100644 --- a/packages/redux-devtools/examples/todomvc/src/containers/TodoApp.tsx +++ b/packages/redux-devtools/examples/todomvc/src/containers/TodoApp.tsx @@ -22,7 +22,6 @@ class TodoApp extends Component { return (
- {/* eslint-disable-next-line @typescript-eslint/unbound-method */}