From f1d61580a81ecfa91aaece981bcf554ead48efbc Mon Sep 17 00:00:00 2001
From: Nathan Bierema <nbierema@gmail.com>
Date: Tue, 3 Sep 2024 21:47:16 -0400
Subject: [PATCH 1/2] Fix mocking Chrome API for Electron (#1748)

* Fix mocking Chrome API for Electron

* Create chilled-feet-marry.md
---
 .changeset/chilled-feet-marry.md         |  5 +++++
 extension/src/app/Actions.tsx            | 10 +++-------
 extension/src/background/index.ts        |  1 +
 extension/src/chromeApiMock.ts           | 20 +++++++++++---------
 extension/test/electron/devpanel.spec.js | 10 +++++-----
 5 files changed, 25 insertions(+), 21 deletions(-)
 create mode 100644 .changeset/chilled-feet-marry.md

diff --git a/.changeset/chilled-feet-marry.md b/.changeset/chilled-feet-marry.md
new file mode 100644
index 00000000..ba1abaad
--- /dev/null
+++ b/.changeset/chilled-feet-marry.md
@@ -0,0 +1,5 @@
+---
+'remotedev-redux-devtools-extension': patch
+---
+
+Fix mocking Chrome API for Electron
diff --git a/extension/src/app/Actions.tsx b/extension/src/app/Actions.tsx
index 216e59af..656bb6d6 100644
--- a/extension/src/app/Actions.tsx
+++ b/extension/src/app/Actions.tsx
@@ -29,11 +29,7 @@ interface OwnProps {
 }
 type Props = StateProps & DispatchProps & OwnProps;
 
-declare global {
-  interface Window {
-    isElectron?: boolean;
-  }
-}
+const isElectron = navigator.userAgent.includes('Electron');
 
 function sendMessage(message: SingleMessage) {
   chrome.runtime.sendMessage(message);
@@ -98,7 +94,7 @@ class Actions extends Component<Props> {
             <DispatcherButton dispatcherIsOpen={this.props.dispatcherIsOpen} />
           )}
           <Divider />
-          {!window.isElectron && (
+          {!isElectron && (
             <Button
               onClick={() => {
                 this.openWindow('window');
@@ -107,7 +103,7 @@ class Actions extends Component<Props> {
               <MdOutlineWindow />
             </Button>
           )}
-          {!window.isElectron && (
+          {!isElectron && (
             <Button
               onClick={() => {
                 this.openWindow('remote');
diff --git a/extension/src/background/index.ts b/extension/src/background/index.ts
index 85732367..f8831473 100644
--- a/extension/src/background/index.ts
+++ b/extension/src/background/index.ts
@@ -1,3 +1,4 @@
+import '../chromeApiMock';
 import configureStore from './store/backgroundStore';
 import openDevToolsWindow, { DevToolsPosition } from './openWindow';
 import { createMenu, removeMenu } from './contextMenus';
diff --git a/extension/src/chromeApiMock.ts b/extension/src/chromeApiMock.ts
index e6c59523..253fd1a4 100644
--- a/extension/src/chromeApiMock.ts
+++ b/extension/src/chromeApiMock.ts
@@ -1,14 +1,11 @@
 // Mock not supported chrome.* API for Firefox and Electron
 
-window.isElectron =
-  window.navigator && window.navigator.userAgent.indexOf('Electron') !== -1;
-
-const isFirefox = navigator.userAgent.indexOf('Firefox') !== -1;
+const isElectron = navigator.userAgent.includes('Electron');
+const isFirefox = navigator.userAgent.includes('Firefox');
 
 // Background page only
 if (
-  (window.isElectron &&
-    location.pathname === '/_generated_background_page.html') ||
+  (isElectron && location.pathname === '/background.bundle.js') ||
   isFirefox
 ) {
   (chrome.runtime as any).onConnectExternal = {
@@ -18,7 +15,7 @@ if (
     addListener() {},
   };
 
-  if (window.isElectron) {
+  if (isElectron) {
     (chrome.notifications as any) = {
       onClicked: {
         addListener() {},
@@ -31,6 +28,11 @@ if (
         addListener() {},
       },
     };
+    (chrome.commands as any) = {
+      onCommand: {
+        addListener() {},
+      },
+    };
   } else {
     (chrome.storage as any).sync = chrome.storage.local;
     (chrome.runtime as any).onInstalled = {
@@ -39,7 +41,7 @@ if (
   }
 }
 
-if (window.isElectron) {
+if (isElectron) {
   if (!chrome.storage.local || !chrome.storage.local.remove) {
     (chrome.storage as any).local = {
       set(obj: any, callback: any) {
@@ -87,6 +89,6 @@ if (window.isElectron) {
   };
 }
 
-if (isFirefox || window.isElectron) {
+if (isFirefox || isElectron) {
   (chrome.storage as any).sync = chrome.storage.local;
 }
diff --git a/extension/test/electron/devpanel.spec.js b/extension/test/electron/devpanel.spec.js
index 5c37daf5..1a7dad60 100644
--- a/extension/test/electron/devpanel.spec.js
+++ b/extension/test/electron/devpanel.spec.js
@@ -6,7 +6,7 @@ import chromedriver from 'chromedriver';
 import { switchMonitorTests, delay } from '../utils/e2e';
 
 const devPanelPath =
-  'chrome-extension://lmhkpmbekcpmknklioeibfkpmmfibljd/window.html';
+  'chrome-extension://lmhkpmbekcpmknklioeibfkpmmfibljd/devpanel.html';
 
 describe('DevTools panel for Electron', function () {
   let driver;
@@ -76,7 +76,7 @@ describe('DevTools panel for Electron', function () {
     expect(className).not.toMatch(/hidden/); // not hidden
   });
 
-  it.skip('should have Redux DevTools UI on current tab', async () => {
+  it('should have Redux DevTools UI on current tab', async () => {
     await driver
       .switchTo()
       .frame(
@@ -87,7 +87,7 @@ describe('DevTools panel for Electron', function () {
     await delay(1000);
   });
 
-  it.skip('should contain INIT action', async () => {
+  it('should contain INIT action', async () => {
     const element = await driver.wait(
       webdriver.until.elementLocated(
         webdriver.By.xpath('//div[@data-testid="actionListRows"]'),
@@ -99,7 +99,7 @@ describe('DevTools panel for Electron', function () {
     expect(val).toMatch(/@@INIT/);
   });
 
-  it.skip("should contain Inspector monitor's component", async () => {
+  it("should contain Inspector monitor's component", async () => {
     const val = await driver
       .findElement(webdriver.By.xpath('//div[@data-testid="inspector"]'))
       .getText();
@@ -107,7 +107,7 @@ describe('DevTools panel for Electron', function () {
   });
 
   Object.keys(switchMonitorTests).forEach((description) =>
-    it.skip(description, () => switchMonitorTests[description](driver)),
+    it(description, () => switchMonitorTests[description](driver)),
   );
 
   /*  it('should be no logs in console of main window', async () => {

From 61c09e1cc39272c5326003cc59aa95ea6142990c Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Wed, 4 Sep 2024 02:07:20 +0000
Subject: [PATCH 2/2] Version Packages (#1749)

* Version Packages

* Bump

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nathan Bierema <nbierema@gmail.com>
---
 .changeset/chilled-feet-marry.md | 5 -----
 extension/CHANGELOG.md           | 6 ++++++
 extension/chrome/manifest.json   | 2 +-
 extension/edge/manifest.json     | 2 +-
 extension/firefox/manifest.json  | 2 +-
 extension/package.json           | 2 +-
 6 files changed, 10 insertions(+), 9 deletions(-)
 delete mode 100644 .changeset/chilled-feet-marry.md

diff --git a/.changeset/chilled-feet-marry.md b/.changeset/chilled-feet-marry.md
deleted file mode 100644
index ba1abaad..00000000
--- a/.changeset/chilled-feet-marry.md
+++ /dev/null
@@ -1,5 +0,0 @@
----
-'remotedev-redux-devtools-extension': patch
----
-
-Fix mocking Chrome API for Electron
diff --git a/extension/CHANGELOG.md b/extension/CHANGELOG.md
index ea2c9671..e3f26bb5 100644
--- a/extension/CHANGELOG.md
+++ b/extension/CHANGELOG.md
@@ -1,5 +1,11 @@
 # remotedev-redux-devtools-extension
 
+## 3.2.4
+
+### Patch Changes
+
+- f1d6158: Fix mocking Chrome API for Electron
+
 ## 3.2.3
 
 ### Patch Changes
diff --git a/extension/chrome/manifest.json b/extension/chrome/manifest.json
index 384bf524..50f554c1 100644
--- a/extension/chrome/manifest.json
+++ b/extension/chrome/manifest.json
@@ -1,5 +1,5 @@
 {
-  "version": "3.2.3",
+  "version": "3.2.4",
   "name": "Redux DevTools",
   "description": "Redux DevTools for debugging application's state changes.",
   "homepage_url": "https://github.com/reduxjs/redux-devtools",
diff --git a/extension/edge/manifest.json b/extension/edge/manifest.json
index 6c9d6661..8aa5365c 100644
--- a/extension/edge/manifest.json
+++ b/extension/edge/manifest.json
@@ -1,5 +1,5 @@
 {
-  "version": "3.2.3",
+  "version": "3.2.4",
   "name": "Redux DevTools",
   "description": "Redux DevTools for debugging application's state changes.",
   "homepage_url": "https://github.com/reduxjs/redux-devtools",
diff --git a/extension/firefox/manifest.json b/extension/firefox/manifest.json
index b1d32eb9..65ec7fbb 100644
--- a/extension/firefox/manifest.json
+++ b/extension/firefox/manifest.json
@@ -1,5 +1,5 @@
 {
-  "version": "3.2.3",
+  "version": "3.2.4",
   "name": "Redux DevTools",
   "manifest_version": 3,
   "description": "Redux Developer Tools for debugging application state changes.",
diff --git a/extension/package.json b/extension/package.json
index e23ba124..ad3fc23f 100644
--- a/extension/package.json
+++ b/extension/package.json
@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "remotedev-redux-devtools-extension",
-  "version": "3.2.3",
+  "version": "3.2.4",
   "description": "Redux Developer Tools for debugging application state changes.",
   "homepage": "https://github.com/reduxjs/redux-devtools/tree/master/extension",
   "license": "MIT",