From 13e93f564a361da38d345f5eca2a411d88324e05 Mon Sep 17 00:00:00 2001
From: Miroslav Stampar <miroslav.stampar@gmail.com>
Date: Tue, 2 Nov 2010 07:32:08 +0000
Subject: [PATCH] one bug fix in dynamic content engine and some code
 refactoring

---
 lib/controller/checks.py          |  2 +-
 lib/core/common.py                | 28 ++++++++++++++++------------
 lib/core/option.py                |  6 ++++--
 lib/request/comparison.py         |  8 ++++----
 lib/techniques/blind/inference.py |  6 ++----
 5 files changed, 27 insertions(+), 23 deletions(-)

diff --git a/lib/controller/checks.py b/lib/controller/checks.py
index c49617e85..43392e4ce 100644
--- a/lib/controller/checks.py
+++ b/lib/controller/checks.py
@@ -185,7 +185,7 @@ def checkDynamicContent(firstPage, secondPage):
             if postfix is None and (blocks[i][0] + blocks[i][2] >= len(firstPage)):
                 continue
 
-            kb.dynamicMarkings.append((prefix[-conf.dynMarkLength:] if prefix else None, postfix[:conf.dynMarkLength] if postfix else None))
+            kb.dynamicMarkings.append((re.escape(prefix[-conf.dynMarkLength:]) if prefix else None, re.escape(postfix[:conf.dynMarkLength]) if postfix else None))
 
     if len(kb.dynamicMarkings) > 0:
         infoMsg = "dynamic content marked for removal (%d region%s)" % (len(kb.dynamicMarkings), 's' if len(kb.dynamicMarkings) > 1 else '')
diff --git a/lib/core/common.py b/lib/core/common.py
index 0ff377e90..48a7fc338 100644
--- a/lib/core/common.py
+++ b/lib/core/common.py
@@ -1239,21 +1239,25 @@ def getConsoleWidth(default=80):
     return width if width else default
 
 def parseXmlFile(xmlFile, handler):
-    if xmlFile not in kb.cache.content:
-        if conf.parseLock:
-            conf.parseLock.acquire()
-        if xmlFile not in kb.cache.content:
-            checkFile(xmlFile)
-            xfile = codecs.open(xmlFile, 'rb', conf.dataEncoding)
-            content = xfile.read()
-            kb.cache.content[xmlFile] = content
-            xfile.close()
-        if conf.parseLock:
-            conf.parseLock.release()
-    stream = StringIO(kb.cache.content[xmlFile])
+    stream = StringIO(readCachedFileContent(xmlFile))
     parse(stream, handler)
     stream.close()
 
+def readCachedFileContent(filename, mode='rb'):
+    if filename not in kb.cache.content:
+        kb.data.cacheLock.acquire()
+
+        if filename not in kb.cache.content:
+            checkFile(filename)
+            xfile = codecs.open(filename, mode, conf.dataEncoding)
+            content = xfile.read()
+            kb.cache.content[filename] = content
+            xfile.close()
+
+        kb.data.cacheLock.release()
+    
+    return kb.cache.content[filename]
+
 def readXmlFile(xmlFile):
     checkFile(xmlFile)  
     xfile = codecs.open(xmlFile, 'r', conf.dataEncoding)
diff --git a/lib/core/option.py b/lib/core/option.py
index 112a4096b..8c0e9a656 100644
--- a/lib/core/option.py
+++ b/lib/core/option.py
@@ -16,6 +16,7 @@ import os
 import re
 import socket
 import sys
+import threading
 import urllib2
 import urlparse
 
@@ -993,7 +994,6 @@ def __setConfAttributes():
     conf.outputPath       = None
     conf.paramDict        = {}
     conf.parameters       = {}
-    conf.parseLock        = None
     conf.path             = None
     conf.port             = None
     conf.redirectHandled  = False
@@ -1001,7 +1001,6 @@ def __setConfAttributes():
     conf.scheme           = None
     #conf.seqMatcher       = difflib.SequenceMatcher(lambda x: x in " \t")
     conf.seqMatcher       = difflib.SequenceMatcher(None)
-    conf.seqLock          = None
     conf.sessionFP        = None
     conf.start            = True
     conf.threadContinue   = True
@@ -1027,7 +1026,10 @@ def __setKnowledgeBaseAttributes():
     kb.cache.regex     = {}
 
     kb.commonOutputs   = None
+
     kb.data            = advancedDict()
+    kb.data.cacheLock  = threading.Lock()
+    kb.data.seqLock    = None
 
     # Basic back-end DBMS fingerprint
     kb.dbms            = None
diff --git a/lib/request/comparison.py b/lib/request/comparison.py
index 9e9fe449f..61e294ec2 100644
--- a/lib/request/comparison.py
+++ b/lib/request/comparison.py
@@ -58,8 +58,8 @@ def comparison(page, headers=None, getSeqMatcher=False, pageLength=None):
         else:
             page = re.sub('(?s)%s.+%s' % (prefix, postfix), '%s%s' % (prefix, postfix), page)
 
-    if conf.seqLock:
-        conf.seqLock.acquire()
+    if kb.data.seqLock:
+        kb.data.seqLock.acquire()
 
     if not conf.eRegexp and not conf.eString and kb.nullConnection:
         ratio = 1. * pageLength / len(conf.seqMatcher.a)
@@ -69,8 +69,8 @@ def comparison(page, headers=None, getSeqMatcher=False, pageLength=None):
         conf.seqMatcher.set_seq2(page if not conf.textOnly else getFilteredPageContent(page))
         ratio = round(conf.seqMatcher.ratio(), 3)
 
-    if conf.seqLock:
-        conf.seqLock.release()
+    if kb.data.seqLock:
+        kb.data.seqLock.release()
 
     # If the url is stable and we did not set yet the match ratio and the
     # current injected value changes the url page content
diff --git a/lib/techniques/blind/inference.py b/lib/techniques/blind/inference.py
index 99ac1e187..7e7a54a82 100644
--- a/lib/techniques/blind/inference.py
+++ b/lib/techniques/blind/inference.py
@@ -251,8 +251,7 @@ def bisection(payload, expression, length=None, charsetType=None, firstChar=None
         idxlock = threading.Lock()
         iolock  = threading.Lock()
         valuelock  = threading.Lock()
-        conf.seqLock = threading.Lock()
-        conf.parseLock = threading.Lock()
+        kb.data.seqLock = threading.Lock()
         conf.threadContinue = True
 
         def downloadThread():
@@ -416,8 +415,7 @@ def bisection(payload, expression, length=None, charsetType=None, firstChar=None
         if conf.verbose >= 1 and not showEta and infoMsg:
             dataToStdout(infoMsg)
 
-        conf.seqLock = None
-        conf.parseLock = None
+        kb.data.seqLock = None
 
     # No multi-threading (--threads = 1)
     else: