From 2c98507f1e2fc7c821b52a9bf41c1d13635e2820 Mon Sep 17 00:00:00 2001 From: Meatballs Date: Sun, 16 Jun 2013 10:27:08 +0100 Subject: [PATCH] Add better error msg --- lib/takeover/xp_cmdshell.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/takeover/xp_cmdshell.py b/lib/takeover/xp_cmdshell.py index 43b640ecc..e0b76af6a 100644 --- a/lib/takeover/xp_cmdshell.py +++ b/lib/takeover/xp_cmdshell.py @@ -106,7 +106,7 @@ class Xp_cmdshell: if output == "1": logger.info("xp_cmdshell extended procedure is usable") - elif isNoneValue(output): + elif isNoneValue(output) and conf.dbmsCred: errMsg = "it seems that the temporary directory ('%s') used for " % self.getRemoteTempPath() errMsg += "storing console output within the back-end file system " errMsg += "does not have writing permissions for the DBMS process. " @@ -114,6 +114,8 @@ class Xp_cmdshell: errMsg += "--tmp-path switch or you will not be able to retrieve " errMsg += "the commands output" logger.error(errMsg) + elif isNoneValue(output): + logger.error("unable to retrieve xp_cmdshell output") else: logger.info("xp_cmdshell extended procedure is usable")