sqlmapproject/sqlmap
1
1
Fork 0
mirror of https://github.com/sqlmapproject/sqlmap.git synced 2025-06-19 12:33:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

Python 3 binary-character fixes for two urllib requests (#4077)

Browse Source 
* Fix python3 binary - character mismatch in api.py

Convert between text and binary data in api.py call to urllib.request
and response from it.

In python3 sqlmapapi -c it fixes, at least
- not nice output from log/list commands
- any command that POSTs data (including new) crashing sqlmapapi

* Fix python3 binary - character mismatch in search.py

Before:
python3 sqlmap.py -g <long random string>
(...)
[18:35:17] [INFO] using search result page #1
no usable links found. What do you want to do?
[1] (re)try with DuckDuckGo (default)
[2] (re)try with Bing
[3] quit
> 1
[18:35:21] [CRITICAL] unable to connect

After:
python3 sqlmap.py -g asfafw2fwesvzsdvaw
(...)
[18:37:30] [INFO] using search result page #1
no usable links found. What do you want to do?
[1] (re)try with DuckDuckGo (default)
[2] (re)try with Bing
[3] quit
> 1
[18:37:34] [INFO] found 26 results for your search dork expression, 16 of them are testable targets
[18:37:34] [INFO] found a total of 16 targets
URL 1:
GET https:...
do you want to test this URL? [Y/n/q]
This commit is contained in:
Tomas Zellerin 2020-01-15 22:36:49 +01:00 committed by Miroslav Stampar
parent c082067902
commit a6c26fe792
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/utils/api.py
View File

@ -713,7 +713,7 @@ def _client(url, options=None):
try: try:
data = None data = None
if options is not None: if options is not None:
data = jsonize(options) data = jsonize(options).encode("utf-8")
headers = {"Content-Type": "application/json"} headers = {"Content-Type": "application/json"}
if DataStore.username or DataStore.password: if DataStore.username or DataStore.password:
@ -721,7 +721,7 @@ def _client(url, options=None):
req = _urllib.request.Request(url, data, headers) req = _urllib.request.Request(url, data, headers)
response = _urllib.request.urlopen(req) response = _urllib.request.urlopen(req)
text = response.read() text = response.read().decode("utf-8")
except: except:
if options: if options:
logger.error("Failed to load and parse %s" % url) logger.error("Failed to load and parse %s" % url)

2
lib/utils/search.py
View File

@ -132,7 +132,7 @@ def _search(dork):
regex = DUCKDUCKGO_REGEX regex = DUCKDUCKGO_REGEX
try: try:
req = _urllib.request.Request(url, data=data, headers=requestHeaders) req = _urllib.request.Request(url, data=data.encode("utf-8"), headers=requestHeaders)
conn = _urllib.request.urlopen(req) conn = _urllib.request.urlopen(req)
requestMsg = "HTTP request:\nGET %s" % url requestMsg = "HTTP request:\nGET %s" % url