minor patch

lib/core/settings.py

@@ -417,4 +417,4 @@ DEFAULT_GET_POST_DELIMITER = '&'
 DEFAULT_COOKIE_DELIMITER = ';'
 
 # Skip unforced HashDB flush requests below the threshold number of cached items
-HASHDB_FLUSH_THRESHOLD = 10
+HASHDB_FLUSH_THRESHOLD = 32

lib/utils/hashdb.py

@@ -90,20 +90,22 @@ class HashDB(object):
         self._write_cache.clear()
         self._cache_lock.release()
 
-        self.beginTransaction()
+        try:
-        for hash_, value in items:
+            self.beginTransaction()
-            while True:
+            for hash_, value in items:
-                try:
+                while True:
                     try:
-                        self.cursor.execute("INSERT INTO storage VALUES (?, ?)", (hash_, value,))
+                        try:
-                    except sqlite3.IntegrityError:
+                            self.cursor.execute("INSERT INTO storage VALUES (?, ?)", (hash_, value,))
-                        self.cursor.execute("UPDATE storage SET value=? WHERE id=?", (value, hash_,))
+                        except sqlite3.IntegrityError:
-                except sqlite3.OperationalError, ex:
+                            self.cursor.execute("UPDATE storage SET value=? WHERE id=?", (value, hash_,))
-                    if not 'locked' in ex.message:
+                    except sqlite3.OperationalError, ex:
-                        raise
+                        if not 'locked' in ex.message:
-                else:
+                            raise
-                    break
+                    else:
-        self.endTransaction()
+                        break
+        finally:
+            self.endTransaction()
 
     def beginTransaction(self):
         self.cursor.execute('BEGIN TRANSACTION')